From: Yicong Yang <yangyicong@hisilicon.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <john.garry@huawei.com>,
<prime.zeng@huawei.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH 2/2] spi: hisi-sfv-v3xx: drop unnecessary ACPI_PTR and related ifendif protection
Date: Fri, 9 Apr 2021 15:17:01 +0800 [thread overview]
Message-ID: <26fad983-9e06-333c-c1b9-332c6acfddfa@hisilicon.com> (raw)
In-Reply-To: <20210408135155.GG4516@sirena.org.uk>
On 2021/4/8 21:51, Mark Brown wrote:
> On Thu, Apr 08, 2021 at 07:31:45PM +0800, Yicong Yang wrote:
>> The ACPI_PTR() and related IS_ENABLED(CONFIG_ACPI) protection is
>> redundant, so drop them.
>
> The driver supports building without ACPI so are you sure these are
> redundant?
>
yes. we're not using any acpi function in this driver. What ifdef macro
and ACPI_PTR() protects is struct acpi_device_id, which is defined in
mod_devicetable.h rather than acpi.h. It can be built when ACPI=n.
some similiar cleanups can be found:
6c328c347ac3 ("platform/x86: i2c-multi-instantiate: Drop redundant ACPI_PTR()")
846afc1dbcbf ("iio: accel: bma220: Drop ACPI_PTR() and accompanying ifdeffery")
[...]
Thanks,
Yicong
next prev parent reply other threads:[~2021-04-09 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:31 [PATCH 0/2] Minor updates for hisi-sfc-v3xx Yicong Yang
2021-04-08 11:31 ` [PATCH 1/2] spi: hisi-sfc-v3xx: fix potential irq race condition Yicong Yang
2021-04-08 11:31 ` [PATCH 2/2] spi: hisi-sfv-v3xx: drop unnecessary ACPI_PTR and related ifendif protection Yicong Yang
2021-04-08 13:51 ` Mark Brown
2021-04-09 7:17 ` Yicong Yang [this message]
2021-04-09 14:25 ` John Garry
2021-04-09 15:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26fad983-9e06-333c-c1b9-332c6acfddfa@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=broonie@kernel.org \
--cc=john.garry@huawei.com \
--cc=linux-spi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).