Re: [PATCH v2 0/4] enable flexspi support on imx8mp

From: Heiko Schocher <hs@denx.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	"Alice Guo" <alice.guo@nxp.com>,
	"Anson Huang" <Anson.Huang@nxp.com>,
	"Ashish Kumar" <ashish.kumar@nxp.com>,
	"Dong Aisheng" <aisheng.dong@nxp.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Horia Geantă" <horia.geanta@nxp.com>,
	"Jacky Bai" <ping.bai@nxp.com>,
	"Joakim Zhang" <qiangqing.zhang@nxp.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Li Jun" <jun.li@nxp.com>, "Mark Brown" <broonie@kernel.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Peng Fan" <peng.fan@nxp.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Teresa Remmet" <t.remmet@phytec.de>,
	"Yogesh Gaur" <yogeshgaur.83@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 0/4] enable flexspi support on imx8mp
Date: Mon, 15 Mar 2021 08:10:37 +0100	[thread overview]
Message-ID: <2c1e4c70-7616-85b3-bfa6-faf81dd72877@denx.de> (raw)
In-Reply-To: <20210315064731.GL11246@dragon>

Hello Shawn,

On 15.03.21 07:47, Shawn Guo wrote:
> On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote:
>>
>> This series enables support for the SPI NOR on the
>> imx8mp based phyboard-pollux-rdk board.
>>
>> Patches new in v2:
>> "spi: fspi: enable fspi driver for on imx8mp"
>> which adds own compatible entry for imx8mp
>>
>> and seperate in own patch the documentation entry in
>> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
>> as checkpatch says:
>>
>> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>>
>>
>> Changes in v2:
>> - work in comments from Marco
>>   add own compatible entry for imx8mp
>> - work in comments from Marco
>>   - add own compatible entry "nxp,imx8mp-fspi"
>>   - reworked order of properties as Marco mentioned
>> - work in comments from Marco and Teresa
>>   - rename node into "'som_flash: flash@0 { }"
>>   - compatible is now first entry
>>   - removed #size-cells and #address-cells
>>     as no child node. If bootloader adds them bootloader
>>     can add them too.
>>
>> Heiko Schocher (4):
>>   spi: fspi: enable fspi driver for on imx8mp
>>   dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
>>     controller
>>   arm64: dts: imx8mp: add flexspi node
>>   arm64: imx8mp: imx8mp-phycore-som enable spi nor
> 
> Two DTS patch look good.  Ping me when driver and bindings changes are
> accepted.

Thanks!

Hmm.. I have not splitted this series into 2 series... should I do
this now?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de