From: "tiantao (H)" <tiantao6@huawei.com>
To: Fabio Estevam <festevam@gmail.com>, Tian Tao <tiantao6@hisilicon.com>
Cc: Mark Brown <broonie@kernel.org>, linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v2] spi: davinci: Use of_device_get_match_data() helper
Date: Tue, 30 Mar 2021 20:47:50 +0800 [thread overview]
Message-ID: <37cc380a-4df3-44b9-9d93-903a80617f77@huawei.com> (raw)
In-Reply-To: <CAOMZO5A8r8LuV_GOvi3=rdABFgWuC3ho=h2B4FwWB_Y-WCXUTg@mail.gmail.com>
在 2021/3/30 20:36, Fabio Estevam 写道:
> On Tue, Mar 30, 2021 at 9:30 AM Tian Tao <tiantao6@hisilicon.com> wrote:
>
>> - match = of_match_device(davinci_spi_of_match, &pdev->dev);
>> - if (!match)
>> + spi_data = of_device_get_match_data(&pdev->dev);
>> + if (!spi_data)
> No need to check against NULL here because all compatible strings
> provide .data and DT is the only mechanism to probe.
>
> Also, this could be device_get_match_data().
> .
What about doing it like this?
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 7453a1d..e114e6fe 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -817,18 +817,13 @@ static int spi_davinci_get_pdata(struct
platform_device *pdev,
struct davinci_spi *dspi)
{
struct device_node *node = pdev->dev.of_node;
- struct davinci_spi_of_data *spi_data;
+ const struct davinci_spi_of_data *spi_data;
struct davinci_spi_platform_data *pdata;
unsigned int num_cs, intr_line = 0;
- const struct of_device_id *match;
pdata = &dspi->pdata;
- match = of_match_device(davinci_spi_of_match, &pdev->dev);
- if (!match)
- return -ENODEV;
-
- spi_data = (struct davinci_spi_of_data *)match->data;
+ spi_data = device_get_match_data(&pdev->dev);
pdata->version = spi_data->version;
pdata->prescaler_limit = spi_data->prescaler_limit;
next prev parent reply other threads:[~2021-03-30 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 12:31 [PATCH v2] spi: davinci: Use of_device_get_match_data() helper Tian Tao
2021-03-30 12:36 ` Fabio Estevam
2021-03-30 12:47 ` tiantao (H) [this message]
2021-03-30 12:49 ` Fabio Estevam
2021-03-30 12:53 ` tiantao (H)
2021-03-30 12:55 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37cc380a-4df3-44b9-9d93-903a80617f77@huawei.com \
--to=tiantao6@huawei.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-spi@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).