From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF75BC433ED for ; Fri, 9 Apr 2021 14:28:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC8FA61185 for ; Fri, 9 Apr 2021 14:28:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233137AbhDIO2f (ORCPT ); Fri, 9 Apr 2021 10:28:35 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2826 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232855AbhDIO2f (ORCPT ); Fri, 9 Apr 2021 10:28:35 -0400 Received: from fraeml734-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FH0c45dkkz687Sl; Fri, 9 Apr 2021 22:18:44 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml734-chm.china.huawei.com (10.206.15.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 9 Apr 2021 16:28:21 +0200 Received: from [10.47.1.29] (10.47.1.29) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 9 Apr 2021 15:28:20 +0100 Subject: Re: [PATCH 2/2] spi: hisi-sfv-v3xx: drop unnecessary ACPI_PTR and related ifendif protection To: Yicong Yang , Mark Brown CC: , , References: <1617881505-51552-1-git-send-email-yangyicong@hisilicon.com> <1617881505-51552-3-git-send-email-yangyicong@hisilicon.com> <20210408135155.GG4516@sirena.org.uk> <26fad983-9e06-333c-c1b9-332c6acfddfa@hisilicon.com> From: John Garry Message-ID: <3869ef5f-eda6-907d-7565-29ae0bbf5dd0@huawei.com> Date: Fri, 9 Apr 2021 15:25:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <26fad983-9e06-333c-c1b9-332c6acfddfa@hisilicon.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.1.29] X-ClientProxiedBy: lhreml716-chm.china.huawei.com (10.201.108.67) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 09/04/2021 08:17, Yicong Yang wrote: > On 2021/4/8 21:51, Mark Brown wrote: >> On Thu, Apr 08, 2021 at 07:31:45PM +0800, Yicong Yang wrote: >>> The ACPI_PTR() and related IS_ENABLED(CONFIG_ACPI) protection is >>> redundant, so drop them. >> >> The driver supports building without ACPI so are you sure these are >> redundant? >> > > yes. we're not using any acpi function in this driver. What ifdef macro > and ACPI_PTR() protects is struct acpi_device_id, which is defined in > mod_devicetable.h rather than acpi.h. It can be built when ACPI=n. > I asked the exact same thing, so another version with an updated commit message with this info could be useful. Mark's call, though. Thanks, John > some similiar cleanups can be found: > 6c328c347ac3 ("platform/x86: i2c-multi-instantiate: Drop redundant ACPI_PTR()") > 846afc1dbcbf ("iio: accel: bma220: Drop ACPI_PTR() and accompanying ifdeffery") > [...] > > Thanks, > Yicong > > . >