From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh Raghavendra Subject: Re: [EXT] Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Date: Mon, 27 Jan 2020 09:51:28 +0530 Message-ID: <3afe0dde-02f7-8f75-4410-efbdb5f91499@ti.com> References: <20191230074102.50982-1-vadivel.muruganx.ramuthevar@linux.intel.com> <860aecbc-22d3-c9ce-3570-44115d6e81b2@ti.com> <40ee10f1-0b30-155c-c165-1baa57a22109@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org" , "cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" To: Kuldeep Singh , "Ramuthevar,Vadivel MuruganX" , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" Return-path: In-Reply-To: Content-Language: en-US Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi, On 23/01/20 5:07 pm, Kuldeep Singh wrote: > Hi Vignesh, > [...] >> I did test with s25fl512s with UBIFS and did not see any issue. > > Thanks Vignesh for this confirmation. > >> Could you try with latest linux master or linux next? There were couple of fixes in the last -rc >> related to spansion flashes? > > Yes, I have already applied those patches and still facing this issue. > I am testing with s25fs512s and only able to make it work on 1bit mode and that too by skipping SFDP. Hmm, why would you need to skip SFDP parsing in 1 bit mode? What actually fails when SFDP is parsed? Read/write/erase? BTW, did s25fs512s flash ever with you controller before (i.e is this a regression)? > Basic read/write works on other modes but not FS utilities. > Could you please share any pointer to look into which direction. Thanks in advance. > If 1 bit mode works fine, then probably flash FS in 1 bit mode and they try read only mount in quad mode. Thus try and narrow down if the issue is in read path vs write path. Regards Vignesh > Thanks > Kuldeep > >> >> [1] >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kerne >> l.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmtd%2Flinux.git%2Fcommit >> %2F%3Fh%3Dmtd%2Ffixes%26id%3D440b6d50254bdbd84c2a665c7f53ec69dd >> 741a4f&data=02%7C01%7Ckuldeep.singh%40nxp.com%7Cee345bdf9f654 >> 4ac9f4508d79fd863d9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7 >> C637153624041330774&sdata=OyKGl2jn5JDq5KCaVrxAnUh4qSynmAhS% >> 2FeFiOxJSKtU%3D&reserved=0 >> [2]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker >> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmtd%2Flinux.git%2Fcomm >> it%2F%3Fh%3Dmtd%2Ffixes%26id%3Dda2ef8124f20b4ce18d1d3d24fc7b88e68 >> 7e10bb&data=02%7C01%7Ckuldeep.singh%40nxp.com%7Cee345bdf9f65 >> 44ac9f4508d79fd863d9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% >> 7C637153624041330774&sdata=BTRzWWY2z6nZncyktDDIdJFwYTp41S%2 >> Buh99QaJ60e1M%3D&reserved=0 >> >>> Thanks >>> Kuldeep >>> >>>> >>>> Regards >>>> Vignesh >>>> >>>> >>> >> >> -- >> Regards >> Vignesh -- Regards Vignesh