From: Pierre Ossman <drzeus-mmc-p3sGCRWkH8CeZLLa646FqQ@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Mikael Starvik <mikael.starvik-VrBV9hrLPhE@public.gmane.org>,
Hans-Peter Nilsson
<hans-peter.nilsson-VrBV9hrLPhE@public.gmane.org>,
Mike Lavender
<mike-UTnDXsALFwNjMdQLN6DIHgC/G2K4zDHf@public.gmane.org>
Subject: Re: [patch 2.6.22-rc4 8/7] mmc_spi cid/csd/ext_csd updates, CRCs on
Date: Sat, 09 Jun 2007 22:55:33 +0200 [thread overview]
Message-ID: <466B13C5.3050502@drzeus.cx> (raw)
In-Reply-To: <200706051013.44971.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
David Brownell wrote:
> Fix some of the "register"/descriptor access glitches in the
> preceding patches:
>
> - Updated internal routines:
> * previous mmc_send_cxd() renamed to mmc_send_cxd_native(); it
> uses native "R2" responses, which include 16 bytes of data.
> * previous mmc_send_ext_csd() becomes new mmc_send_cxd_data()
> helper for command-and-data access
>
> - Modified mmc_send_ext_csd() now uses mmc_send_cxd_data() helper
>
> - New mmc_send_csd() and mmc_spi_send_cid() routines now use one
> of those helper routines based on whether they're native or SPI;
>
> - Remove ugly "R1D" response pseudo-type for SPI
>
> - Make it OK for MMC cards to try SEND_EXT_CSD; v4+ needs that
>
> - Turn CRCs back on by default with the SPI protocol
>
> So this resolves most of the technical issues I know about, leaving
> nontechnical ones like "is this code clean enough" or "is this how
> we want to solve that problem".
>
> Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Instead of me reviewing the broken set of patches, can you merge these fixes in
and resend the set?
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-06-09 20:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 3:25 [patch 2.6.22-rc4 0/7] latest MMC-over-SPI patchset David Brownell
[not found] ` <200706042025.18252.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-05 3:26 ` [patch 2.6.22-rc4 1/7] CRC7 support David Brownell
2007-06-05 3:28 ` [patch 2.6.22-rc4 2/7] SD 4wire bugfix David Brownell
2007-06-05 3:31 ` [patch 2.6.22-rc4 3/7] SPI "exclusive access" (experimental) David Brownell
2007-06-05 3:34 ` [patch 2.6.22-rc4 4/7] MMC headers understand SPI David Brownell
2007-06-05 3:37 ` [patch 2.6.22-rc4 5/7] MMC core understands SPI David Brownell
2007-06-05 3:38 ` [patch 2.6.22-rc4 6/7] MMC block " David Brownell
2007-06-05 3:50 ` [patch 2.6.22-rc4 7/7] mmc_spi host driver David Brownell
2007-06-05 17:13 ` [patch 2.6.22-rc4 8/7] mmc_spi cid/csd/ext_csd updates, CRCs on David Brownell
[not found] ` <200706051013.44971.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-09 20:55 ` Pierre Ossman [this message]
[not found] ` <466B13C5.3050502-p3sGCRWkH8CeZLLa646FqQ@public.gmane.org>
2007-06-10 19:43 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466B13C5.3050502@drzeus.cx \
--to=drzeus-mmc-p3sgcrwkh8cezlla646fqq@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=hans-peter.nilsson-VrBV9hrLPhE@public.gmane.org \
--cc=mikael.starvik-VrBV9hrLPhE@public.gmane.org \
--cc=mike-UTnDXsALFwNjMdQLN6DIHgC/G2K4zDHf@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).