linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Fang <f.fangjian@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <huangdaode@huawei.com>,
	<linuxarm@huawei.com>
Subject: Re: [PATCH V2] spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs
Date: Sat, 20 Mar 2021 17:44:58 +0800	[thread overview]
Message-ID: <49383980-62e4-08b2-f594-e00abab44749@huawei.com> (raw)
In-Reply-To: <20210318132821.GH5469@sirena.org.uk>

Dear Mark,

On 2021/3/18 21:28, Mark Brown wrote:
> On Thu, Mar 18, 2021 at 05:50:24PM +0800, Jay Fang wrote:
> 
>> Changes in v2:
>> - Use a more specific name (Kunpeng SoCs) for this driver.
> 
>>  drivers/spi/spi-hisi.c | 505 +++++++++++++++++++++++++++++++++++++++++++++++++
> 
>> +config SPI_HISI
>> +	tristate "HiSilicon SPI Controller for Kunpeng SoCs"
> 
> You've changed the display name for the driver but the Kconfig symbol
> and filename are still very generic - can you update them as well
> please?
> 
Will change.

Thanks

> Otherwise this looks good.
> 



      reply	other threads:[~2021-03-20 11:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18  9:50 [PATCH V2] spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs Jay Fang
2021-03-18 13:28 ` Mark Brown
2021-03-20  9:44   ` Jay Fang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49383980-62e4-08b2-f594-e00abab44749@huawei.com \
    --to=f.fangjian@huawei.com \
    --cc=broonie@kernel.org \
    --cc=huangdaode@huawei.com \
    --cc=linux-spi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).