From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D365C433DB for ; Sat, 20 Mar 2021 11:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A7F461996 for ; Sat, 20 Mar 2021 11:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbhCTLum (ORCPT ); Sat, 20 Mar 2021 07:50:42 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3910 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbhCTLuM (ORCPT ); Sat, 20 Mar 2021 07:50:12 -0400 Received: from dggeme758-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4F2bRC1pDgz5dxh; Sat, 20 Mar 2021 17:43:03 +0800 (CST) Received: from [127.0.0.1] (10.40.188.234) by dggeme758-chm.china.huawei.com (10.3.19.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Sat, 20 Mar 2021 17:44:58 +0800 Subject: Re: [PATCH V2] spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs To: Mark Brown CC: , , References: <1616061024-57818-1-git-send-email-f.fangjian@huawei.com> <20210318132821.GH5469@sirena.org.uk> From: Jay Fang Message-ID: <49383980-62e4-08b2-f594-e00abab44749@huawei.com> Date: Sat, 20 Mar 2021 17:44:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210318132821.GH5469@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.188.234] X-ClientProxiedBy: dggeme704-chm.china.huawei.com (10.1.199.100) To dggeme758-chm.china.huawei.com (10.3.19.104) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Dear Mark, On 2021/3/18 21:28, Mark Brown wrote: > On Thu, Mar 18, 2021 at 05:50:24PM +0800, Jay Fang wrote: > >> Changes in v2: >> - Use a more specific name (Kunpeng SoCs) for this driver. > >> drivers/spi/spi-hisi.c | 505 +++++++++++++++++++++++++++++++++++++++++++++++++ > >> +config SPI_HISI >> + tristate "HiSilicon SPI Controller for Kunpeng SoCs" > > You've changed the display name for the driver but the Kconfig symbol > and filename are still very generic - can you update them as well > please? > Will change. Thanks > Otherwise this looks good. >