From: "Richard Röjfors" <richard.rojfors@mocean-labs.com>
To: John Linn <John.Linn@xilinx.com>
Cc: spi-devel-general@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
dbrownell@users.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part.
Date: Thu, 12 Nov 2009 18:22:40 +0100 [thread overview]
Message-ID: <4AFC4460.9050508@mocean-labs.com> (raw)
In-Reply-To: <38eacaec-f0d3-436c-b461-40b5d795cdd9@VA3EHSMHS009.ehs.local>
On 11/12/09 6:17 PM, John Linn wrote:
>> Have you compile tested this? platform_data is a void*, the
>> dereference will not work. I know you don't have hardware; but
>> getting the needed cross compiler is easy.
>
> Here's the fixes I did to make it compile. On to testing :)
Great! I tested this against a max7301 GPIO expander.
--Richard
prev parent reply other threads:[~2009-11-12 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 14:26 [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part Richard Röjfors
2009-11-12 14:56 ` Grant Likely
2009-11-12 15:36 ` Richard Röjfors
2009-11-12 17:17 ` John Linn
2009-11-12 17:22 ` Richard Röjfors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFC4460.9050508@mocean-labs.com \
--to=richard.rojfors@mocean-labs.com \
--cc=John.Linn@xilinx.com \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).