[PATCH v3 0/4] xilinx_spi: Split into platform and of driver, support new IP, platform independence.

[PATCH v3 0/4] xilinx_spi: Split into platform and of driver, support new IP, platform independence.

[Richard Röjfors]

Hi,

To follow is a series of patches against the xilinx_spi driver.

The patchset is against 2.6.32-rc6

The patchset addresses several problems in the current driver:
* It's PPC only (OF and uses PPC specific memory operations)
* Only supporting big endian writes
* Supports only 8bit SPI, support for DS570 (also 16 or 32 bit) is added.
* A platform driver is introduced for non OF capable architectures.

These patches were posted as one big patch up to 4 iterations, not splitted into 4.

This version, 3, is updated after review from Grant Likely and John Linn

John Linn has also tested the code on PPC, I have only tested on X86.

--Richard

Re: [PATCH v3 0/4] xilinx_spi: Split into platform and of driver, support new IP, platform independence.

[Grant Likely]

On Fri, Nov 13, 2009 at 5:28 AM, Richard Röjfors
<richard.rojfors@mocean-labs.com> wrote:
> Hi,
>
> To follow is a series of patches against the xilinx_spi driver.
>
> The patchset is against 2.6.32-rc6
>
> The patchset addresses several problems in the current driver:
> * It's PPC only (OF and uses PPC specific memory operations)
> * Only supporting big endian writes
> * Supports only 8bit SPI, support for DS570 (also 16 or 32 bit) is added.
> * A platform driver is introduced for non OF capable architectures.
>
> These patches were posted as one big patch up to 4 iterations, not splitted into 4.
>
> This version, 3, is updated after review from Grant Likely and John Linn
>
> John Linn has also tested the code on PPC, I have only tested on X86.

Applied to my 'test' branch on git.secretlab.ca.  There was a conflict
on patch 3/4 with a previous bugfix from John Linn.  Please check that
I've fixed it up correctly.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

RE: [PATCH v3 0/4] xilinx_spi: Split into platform and of driver, support new IP, platform independence.

[John Linn]

> -----Original Message-----
> From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Grant Likely
> Sent: Friday, November 13, 2009 11:30 AM
> To: Richard Röjfors
> Cc: spi-devel-general@lists.sourceforge.net; linuxppc-dev@ozlabs.org; Andrew Morton;
> dbrownell@users.sourceforge.net; John Linn
> Subject: Re: [PATCH v3 0/4] xilinx_spi: Split into platform and of driver, support new IP, platform
> independence.
> 
> On Fri, Nov 13, 2009 at 5:28 AM, Richard Röjfors
> <richard.rojfors@mocean-labs.com> wrote:
> > Hi,
> >
> > To follow is a series of patches against the xilinx_spi driver.
> >
> > The patchset is against 2.6.32-rc6
> >
> > The patchset addresses several problems in the current driver:
> > * It's PPC only (OF and uses PPC specific memory operations)
> > * Only supporting big endian writes
> > * Supports only 8bit SPI, support for DS570 (also 16 or 32 bit) is added.
> > * A platform driver is introduced for non OF capable architectures.
> >
> > These patches were posted as one big patch up to 4 iterations, not splitted into 4.
> >
> > This version, 3, is updated after review from Grant Likely and John Linn
> >
> > John Linn has also tested the code on PPC, I have only tested on X86.
> 
> Applied to my 'test' branch on git.secretlab.ca.  There was a conflict
> on patch 3/4 with a previous bugfix from John Linn.  Please check that
> I've fixed it up correctly.

I think I reverted that change as Richard's fixes it I believe.

> 
> Cheers,
> g.
> 
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Re: [PATCH v3 0/4] xilinx_spi: Split into platform and of driver, support new IP, platform independence.

[Grant Likely]

On Fri, Nov 13, 2009 at 12:59 PM, John Linn <John.Linn@xilinx.com> wrote:
>> -----Original Message-----
>> From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Grant Likely
>> Sent: Friday, November 13, 2009 11:30 AM
>> To: Richard Röjfors
>> Cc: spi-devel-general@lists.sourceforge.net; linuxppc-dev@ozlabs.org; Andrew Morton;
>> dbrownell@users.sourceforge.net; John Linn
>> Subject: Re: [PATCH v3 0/4] xilinx_spi: Split into platform and of driver, support new IP, platform
>> independence.
>>
>> On Fri, Nov 13, 2009 at 5:28 AM, Richard Röjfors
>> <richard.rojfors@mocean-labs.com> wrote:
>> > Hi,
>> >
>> > To follow is a series of patches against the xilinx_spi driver.
>> >
>> > The patchset is against 2.6.32-rc6
>> >
>> > The patchset addresses several problems in the current driver:
>> > * It's PPC only (OF and uses PPC specific memory operations)
>> > * Only supporting big endian writes
>> > * Supports only 8bit SPI, support for DS570 (also 16 or 32 bit) is added.
>> > * A platform driver is introduced for non OF capable architectures.
>> >
>> > These patches were posted as one big patch up to 4 iterations, not splitted into 4.
>> >
>> > This version, 3, is updated after review from Grant Likely and John Linn
>> >
>> > John Linn has also tested the code on PPC, I have only tested on X86.
>>
>> Applied to my 'test' branch on git.secretlab.ca.  There was a conflict
>> on patch 3/4 with a previous bugfix from John Linn.  Please check that
>> I've fixed it up correctly.
>
> I think I reverted that change as Richard's fixes it I believe.

It is a real bug fix, and so should be in a separate patch.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.