From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Mallon Subject: Re: [PATCH v5 04/12] spi: add ti-ssp spi master driver Date: Tue, 16 Nov 2010 10:59:59 +1300 Message-ID: <4CE1AD5F.4020401@bluewatersys.com> References: <1289848334-8695-1-git-send-email-cyril@ti.com> <1289848334-8695-5-git-send-email-cyril@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: davinci-linux-open-source@linux.davincidsp.com, dbrownell@users.sourceforge.net, sameo@linux.intel.com, khilman@deeprootsystems.com, linus.ml.walleij@gmail.com, broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca, rpurdie@rpsys.net, alan@lxorguk.ukuu.org.uk, spi-devel-general@lists.sourceforge.net, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, lrg@slimlogic.co.uk To: Cyril Chemparathy Return-path: In-Reply-To: <1289848334-8695-5-git-send-email-cyril@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 11/16/2010 08:12 AM, Cyril Chemparathy wrote: > This patch adds an SPI master implementation that operates on top of an > underlying TI-SSP port. > > Signed-off-by: Cyril Chemparathy > --- > drivers/mfd/Kconfig | 10 + > drivers/mfd/Makefile | 1 + > drivers/mfd/ti-ssp-spi.c | 402 ++++++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/ti_ssp.h | 6 + > 4 files changed, 419 insertions(+), 0 deletions(-) > create mode 100644 drivers/mfd/ti-ssp-spi.c This should live in drivers/spi rather than drivers/mfd. Each of the drivers which use the TI-SSP core are single function drivers and having them in the appropriate directory makes them easier to find. The SSP core driver could either live in drivers/mfd or drivers/misc atmel-ssc.c is in drivers/misc for example. ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St ryan@bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 3779135 USA 1800 261 2934