From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: spi-devel-general@lists.sourceforge.net, linux-mtd@lists.infradead.org
Subject: Re: [PATCH/RFC 2/2] mtd: m25p80: Call a platform power method in the driver
Date: Sun, 28 Aug 2011 13:29:13 +0300 [thread overview]
Message-ID: <4E5A1879.2000508@mm-sol.com> (raw)
In-Reply-To: <20110828052215.GA7033@sapphire.tkos.co.il>
Hi, Baruch
Thanks for the comments !
Baruch Siach wrote:
> Hi Stanimir,
>
> On Thu, Aug 25, 2011 at 04:29:12PM +0300, Stanimir Varbanov wrote:
>> On some devices the flash chip could be powered off when m25p driver
>> is probed. To avoid erroneous detection the power of the chip must be
>> turn on, add a power function in m25p_probe to switch on the power by
>> platform data. The power will be turned off at the probe end.
>
> [snip]
>
>> + /* power on device while probing */
>> + m25p_power(data, 1);
>
> [snip]
>
>> +out:
>> + m25p_power(data, 0);
>
> Shouldn't you power off in m25p_remove() as well?
>
IMO, no, because m25p_power(off) is called from m25p_put_device(). Then
m25p_put_device() is called from mtdchar::mtd_close(). m25p_remove must
fail if user didn't close mtdchar /dev/mtdX device.
The motivation to use power on/off in m25p_probe is because the flash
chip might be not powered when driver probe is called. The chip is powered
on on the probe begging and powered off after JEDEC probe pass.
> baruch
>
regards,
Stan
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2011-08-28 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 13:29 [PATCH/RFC 0/2] Add power supply switch in platform data Stanimir Varbanov
2011-08-25 13:29 ` [PATCH/RFC 1/2] spi: flash: Add power method into flash " Stanimir Varbanov
2011-08-25 13:29 ` [PATCH/RFC 2/2] mtd: m25p80: Call a platform power method in the driver Stanimir Varbanov
2011-08-28 5:22 ` Baruch Siach
2011-08-28 10:29 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5A1879.2000508@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=baruch@tkos.co.il \
--cc=linux-mtd@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).