From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
Cc: Linux DaVinci Kernel List
<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
Linux OMAP List
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Linux Documentation List
<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Linux MMC List
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Dan Williams <djbw-b10kYP2dOMg@public.gmane.org>,
Linux SPI Devel List
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>,
Linux ARM Kernel List
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [RFC PATCH v3 04/16] ARM: edma: add DT and runtime PM support for AM33XX
Date: Sun, 28 Oct 2012 16:33:39 +0530 [thread overview]
Message-ID: <508D110B.8010908@ti.com> (raw)
In-Reply-To: <1350566815-409-5-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
On 10/18/2012 6:56 PM, Matt Porter wrote:
> Adds support for parsing the TI EDMA DT data into the required
> EDMA private API platform data.
>
> Calls runtime PM API only in the DT case in order to unidle the
> associated hwmods on AM33XX.
Runtime PM is supported on DaVinci now, so if that was the reason for
this choice, then it doesn't need to be that way.
>
> Signed-off-by: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/common/edma.c | 255 +++++++++++++++++++++++++--
> arch/arm/mach-davinci/board-da830-evm.c | 4 +-
> arch/arm/mach-davinci/board-da850-evm.c | 8 +-
> arch/arm/mach-davinci/board-dm646x-evm.c | 4 +-
> arch/arm/mach-davinci/board-omapl138-hawk.c | 8 +-
> arch/arm/mach-davinci/devices-da8xx.c | 8 +-
> arch/arm/mach-davinci/devices-tnetv107x.c | 4 +-
> arch/arm/mach-davinci/dm355.c | 4 +-
> arch/arm/mach-davinci/dm365.c | 4 +-
> arch/arm/mach-davinci/dm644x.c | 4 +-
> arch/arm/mach-davinci/dm646x.c | 4 +-
> include/linux/platform_data/edma.h | 8 +-
> 12 files changed, 272 insertions(+), 43 deletions(-)
>
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index a3d189d..6d2a590 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c
> @@ -24,6 +24,13 @@
> #include <linux/platform_device.h>
> #include <linux/io.h>
> #include <linux/slab.h>
> +#include <linux/edma.h>
> +#include <linux/err.h>
> +#include <linux/of_address.h>
> +#include <linux/of_device.h>
> +#include <linux/of_dma.h>
> +#include <linux/of_irq.h>
> +#include <linux/pm_runtime.h>
>
> #include <linux/platform_data/edma.h>
>
> @@ -1366,31 +1373,237 @@ void edma_clear_event(unsigned channel)
> EXPORT_SYMBOL(edma_clear_event);
>
> /*-----------------------------------------------------------------------*/
> +static int edma_of_read_u32_to_s8_array(const struct device_node *np,
> + const char *propname, s8 *out_values,
> + size_t sz)
> +{
> + struct property *prop = of_find_property(np, propname, NULL);
> + const __be32 *val;
> +
> + if (!prop)
> + return -EINVAL;
> + if (!prop->value)
> + return -ENODATA;
> + if ((sz * sizeof(u32)) > prop->length)
> + return -EOVERFLOW;
> +
> + val = prop->value;
> +
> + while (sz--)
> + *out_values++ = (s8)(be32_to_cpup(val++) & 0xff);
> +
> + /* Terminate it */
> + *out_values++ = -1;
> + *out_values++ = -1;
> +
> + return 0;
> +}
> +
> +static int edma_of_read_u32_to_s16_array(const struct device_node *np,
> + const char *propname, s16 *out_values,
> + size_t sz)
> +{
> + struct property *prop = of_find_property(np, propname, NULL);
> + const __be32 *val;
> +
> + if (!prop)
> + return -EINVAL;
> + if (!prop->value)
> + return -ENODATA;
> + if ((sz * sizeof(u32)) > prop->length)
> + return -EOVERFLOW;
> +
> + val = prop->value;
> +
> + while (sz--)
> + *out_values++ = (s16)(be32_to_cpup(val++) & 0xffff);
> +
> + /* Terminate it */
> + *out_values++ = -1;
> + *out_values++ = -1;
> +
> + return 0;
> +}
I think these helper functions will have some general use beyond EDMA
and can be kept in drivers/of/base.c. Grant/Rob need to agree though.
> diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c
> index 95b5e10..ffcbec1 100644
> --- a/arch/arm/mach-davinci/board-da830-evm.c
> +++ b/arch/arm/mach-davinci/board-da830-evm.c
> @@ -512,7 +512,7 @@ static struct davinci_i2c_platform_data da830_evm_i2c_0_pdata = {
> * example: Timer, GPIO, UART events etc) on da830/omap-l137 EVM, hence
> * they are being reserved for codecs on the DSP side.
> */
> -static const s16 da830_dma_rsv_chans[][2] = {
> +static s16 da830_dma_rsv_chans[][2] = {
I wonder why you had to remove const here and in other places. You seem
to be allocating new memory for DT case anyway. Its also not a good idea
to modify the passed platform data.
Thanks,
Sekhar
next prev parent reply other threads:[~2012-10-28 11:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 13:26 [RFC PATCH v3 00/16] DMA Engine support for AM33XX Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 01/16] dmaengine: edma: fix slave config dependency on direction Matt Porter
[not found] ` <1350566815-409-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-18 13:26 ` [RFC PATCH v3 02/16] ARM: davinci: move private EDMA API to arm/common Matt Porter
[not found] ` <1350566815-409-3-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-28 8:17 ` Sekhar Nori
2012-11-16 16:49 ` Matt Porter
2013-01-10 23:51 ` Matt Porter
2013-01-22 15:40 ` Sekhar Nori
[not found] ` <d631bf39a8b8474bae448d089497fe0e@DLEE74.ent.ti.com>
2013-01-23 21:00 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 03/16] ARM: edma: remove unused transfer controller handlers Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 04/16] ARM: edma: add DT and runtime PM support for AM33XX Matt Porter
[not found] ` <1350566815-409-5-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-28 11:03 ` Sekhar Nori [this message]
2013-01-10 19:18 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 05/16] ARM: edma: add AM33XX crossbar event support Matt Porter
[not found] ` <1350566815-409-6-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-26 12:53 ` Hebbar, Gururaja
2012-10-28 11:11 ` Sekhar Nori
2013-01-10 22:54 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 06/16] dmaengine: edma: enable build for AM33XX Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 07/16] dmaengine: edma: Add TI EDMA device tree binding Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 08/16] ARM: dts: add AM33XX EDMA support Matt Porter
[not found] ` <1350566815-409-9-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-28 11:16 ` Sekhar Nori
[not found] ` <508D1414.2000506-l0cyMroinI0@public.gmane.org>
2013-01-10 19:27 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 09/16] dmaengine: add dma_request_slave_channel_compat() Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 10/16] mmc: omap_hsmmc: convert to dma_request_slave_channel_compat() Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 11/16] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC Matt Porter
[not found] ` <1350566815-409-12-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-29 8:18 ` Sekhar Nori
2013-01-10 19:30 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 12/16] mmc: omap_hsmmc: add generic DMA request support to the DT binding Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 13/16] ARM: dts: add AM33XX MMC support Matt Porter
[not found] ` <1350566815-409-14-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-30 5:33 ` AnilKumar, Chimata
2013-01-10 20:26 ` Matt Porter
2013-01-03 10:03 ` Hebbar, Gururaja
2012-10-18 13:26 ` [RFC PATCH v3 14/16] spi: omap2-mcspi: convert to dma_request_slave_channel_compat() Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 15/16] spi: omap2-mcspi: add generic DMA request support to the DT binding Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 16/16] ARM: dts: add AM33XX SPI support Matt Porter
[not found] ` <1350566815-409-17-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-10-28 11:31 ` Sekhar Nori
[not found] ` <508D1791.1040806-l0cyMroinI0@public.gmane.org>
2013-01-10 19:35 ` Matt Porter
2013-01-10 19:46 ` Nishanth Menon
2013-01-10 20:49 ` Matt Porter
2013-01-10 20:49 ` Nishanth Menon
2012-10-29 9:11 ` Philip, Avinash
2012-10-30 9:41 ` Philip, Avinash
[not found] ` <518397C60809E147AF5323E0420B992E3E9D597B-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-10-31 10:16 ` Benoit Cousson
[not found] ` <5090FA92.1080400-l0cyMroinI0@public.gmane.org>
2012-10-31 10:35 ` Benoit Cousson
2012-10-31 11:03 ` Philip, Avinash
2012-10-19 10:26 ` [RFC PATCH v3 00/16] DMA Engine support for AM33XX Bedia, Vaibhav
2012-10-19 11:15 ` Matt Porter
2012-10-19 12:02 ` Bedia, Vaibhav
2012-10-19 16:46 ` Matt Porter
2012-10-22 5:53 ` Bedia, Vaibhav
2012-10-26 8:32 ` Russ Dill
2012-11-05 7:19 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508D110B.8010908@ti.com \
--to=nsekhar-l0cymroini0@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=djbw-b10kYP2dOMg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mporter-l0cyMroinI0@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).