From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
To: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: <dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
<tthayer-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>,
<axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>,
<baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT.
Date: Fri, 17 Oct 2014 08:55:21 -0500 [thread overview]
Message-ID: <54411FC9.3050109@opensource.altera.com> (raw)
In-Reply-To: <20141017065233.GA10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On 10/17/2014 01:52 AM, Steffen Trumtrar wrote:
> Hi!
>
> On Thu, Oct 16, 2014 at 05:07:31PM -0500, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote:
>> From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
>>
>> Add 2 SPI nodes to SOCFPGA device tree.
>>
>> Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
>> ---
>> v2: Remove extra files. Move SPIDEV into board specific file.
>>
>> v3: Remove dts file since SPIDEV is not allowed.
>> ---
>> arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
>> index 4d77ad6..d81bc2d3 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -628,6 +628,30 @@
>> clock-names = "biu", "ciu";
>> };
>>
>> + spi0: spi@fff00000 {
>> + compatible = "snps,dw-apb-ssi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0xfff00000 0x1000>;
>> + interrupts = <0 154 4>;
>> + num-cs = <4>;
>> + bus-num = <0>;
> ^^^^^^^^^^^^^^
>
> I think you can/should get rid of this property. It is only used/documented for
> fsl-dspi as far as I can see.
Hi Steffen!
You are right, I will remove this.
I didn't see it documented in the dw-spi bindings but I did see a
reference to .bus_num in the static structure (spi_board_info) shown in
spi-summary.txt. If the bus-num isn't defined or used, the bus ends up
as 32766 (0x7FE). However, the main point is that this isn't used in the
code so I should remove it.
Thanks for your input and for reviewing!
Thor
>> + clocks = <&spi_m_clk>;
>> + status = "disabled";
>> + };
>> +
>> + spi1: spi@fff01000 {
>> + compatible = "snps,dw-apb-ssi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0xfff01000 0x1000>;
>> + interrupts = <0 156 4>;
>> + num-cs = <4>;
>> + bus-num = <1>;
>> + clocks = <&spi_m_clk>;
>> + status = "disabled";
>> + };
>> +
>> /* Local timer */
>> timer@fffec600 {
>> compatible = "arm,cortex-a9-twd-timer";
> The rest looks good IMO.
>
> Regards,
> Steffen
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-17 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 22:07 [PATCHv3] Add SPI nodes to Altera SOCFPGA DT tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1413497251-21954-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-16 22:07 ` [PATCHv3] arm: dts: socfpga: Add SPI nodes to " tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1413497251-21954-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-17 6:52 ` Steffen Trumtrar
[not found] ` <20141017065233.GA10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-10-17 11:13 ` Mark Brown
2014-10-17 13:55 ` Thor Thayer [this message]
[not found] ` <54411FC9.3050109-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-17 14:27 ` Mark Brown
[not found] ` <20141017142713.GV1820-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-10-17 15:05 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54411FC9.3050109@opensource.altera.com \
--to=tthayer-yzvpicuk2abmcg4ihk0kfoh6mc4mb0vx@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=tthayer-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org \
--cc=tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).