From: Guenter Roeck <linux@roeck-us.net>
To: Grant Likely <grant.likely@secretlab.ca>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Rob Herring <robherring2@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Matt Porter <matt.porter@linaro.org>,
Koen Kooi <koen@dominion.thruhere.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alison Chaiken <Alison_Chaiken@mentor.com>,
Dinh Nguyen <dinh.linux@gmail.com>, Jan Lubbe <jluebbe@lasnet.de>,
Alexander Sverdlin <alexander.sverdlin@nsn.com>,
Michael Stickel <ms@mycable.de>,
Dirk Behme <dirk.behme@gmail.com>,
Alan Tull <delicious.quinoa@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Michael Bohan <mbohan@codeaurora.org>,
Ionut Nicu <ioan.nicu.ext@nsn.com>,
Michal Simek <monstr@monstr.eu>,
Matt Ranostay <mranostay@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
devicetree@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Pete Po
Subject: Re: [PATCH v8 6/8] OF: i2c: Add OF notifier handler
Date: Thu, 20 Nov 2014 18:03:33 -0800 [thread overview]
Message-ID: <546E9D75.3000208@roeck-us.net> (raw)
In-Reply-To: <20141121015335.99BF2C413E8@trevor.secretlab.ca>
On 11/20/2014 05:53 PM, Grant Likely wrote:
> On Tue, 28 Oct 2014 22:36:03 +0200
> , Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> wrote:
>> Add OF notifier handler needed for creating/destroying i2c devices
>> according to dynamic runtime changes in the DT live tree.
>>
>> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>> ---
>> drivers/i2c/i2c-core.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 78 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
>> index e6da9d3..e751b78 100644
>> --- a/drivers/i2c/i2c-core.c
>> +++ b/drivers/i2c/i2c-core.c
>> @@ -1470,6 +1470,7 @@ struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node *node)
>> return i2c_verify_adapter(dev);
>> }
>> EXPORT_SYMBOL(of_find_i2c_adapter_by_node);
>> +
>> #else
>> static void of_i2c_register_devices(struct i2c_adapter *adap) { }
>> #endif /* CONFIG_OF */
>> @@ -1955,6 +1956,71 @@ void i2c_clients_command(struct i2c_adapter *adap, unsigned int cmd, void *arg)
>> }
>> EXPORT_SYMBOL(i2c_clients_command);
>>
>> +#if IS_ENABLED(CONFIG_OF)
>> +
>> +static int of_i2c_notify(struct notifier_block *nb,
>> + unsigned long action, void *arg)
>> +{
>> + struct device_node *dn;
>> + struct i2c_adapter *adap;
>> + struct i2c_client *client;
>> + int state;
>> +
>> + state = of_reconfig_get_state_change(action, arg);
>> + if (state == -1)
>> + return NOTIFY_OK;
>> +
>> + switch (action) {
>> + case OF_RECONFIG_ATTACH_NODE:
>> + case OF_RECONFIG_DETACH_NODE:
>> + dn = arg;
>> + break;
>> + case OF_RECONFIG_ADD_PROPERTY:
>> + case OF_RECONFIG_REMOVE_PROPERTY:
>> + case OF_RECONFIG_UPDATE_PROPERTY:
>> + dn = ((struct of_prop_reconfig *)arg)->dn;
>> + break;
>> + default:
>> + return NOTIFY_OK;
>> + }
>> +
>> + if (state) {
>> +
>> + adap = of_find_i2c_adapter_by_node(dn->parent);
>> + if (adap == NULL)
>> + return NOTIFY_OK; /* not for us */
>> +
>> + client = of_i2c_register_device(adap, dn);
>> + put_device(&adap->dev);
>> +
>> + if (IS_ERR(client)) {
>> + pr_err("%s: failed to create for '%s'\n",
>> + __func__, dn->full_name);
>> + return notifier_from_errno(PTR_ERR(client));
>> + }
>> +
>> + } else {
>> +
>> + /* find our device by node */
>> + client = of_find_i2c_device_by_node(dn);
>> + if (client == NULL)
>> + return NOTIFY_OK; /* no? not meant for us */
>> +
>> + /* unregister takes one ref away */
>> + i2c_unregister_device(client);
>> +
>> + /* and put the reference of the find */
>> + put_device(&client->dev);
>> +
>> + }
>
> Nit: odd whitespace
>
>> +
>> + return NOTIFY_OK;
>> +}
>> +
>> +static struct notifier_block i2c_of_notifier;
>> +
>> +#endif
>> +
>> static int __init i2c_init(void)
>> {
>> int retval;
>> @@ -1972,8 +2038,19 @@ static int __init i2c_init(void)
>> retval = i2c_add_driver(&dummy_driver);
>> if (retval)
>> goto class_err;
>> - return 0;
>>
>> +#if IS_ENABLED(CONFIG_OF)
>> + i2c_of_notifier.notifier_call = of_i2c_notify;
Wouldn't it be easier to just initialize i2c_of_notifier above instead of
here in the code ? Or is there a reason for doing it here ?
Thanks,
Guenter
>> + retval = of_reconfig_notifier_register(&i2c_of_notifier);
>> + if (retval)
>> + goto notifier_err;
>> +#endif
>> +
>> + return 0;
>> +#if IS_ENABLED(CONFIG_OF)
>> +notifier_err:
>> + i2c_del_driver(&dummy_driver);
>> +#endif
>
> Similar to my comment on the platform bus, don't break the entire bus if
> registration of the notifier fails. I would drop the error case and just
> do a WARN_ON() if it fails.
>
> Otherwise:
>
> Acked-by: Grant Likely <grant.likely@linaro.org>
>
>> class_err:
>> #ifdef CONFIG_I2C_COMPAT
>> class_compat_unregister(i2c_adapter_compat_class);
>> --
>> 1.7.12
>>
>
>
next prev parent reply other threads:[~2014-11-21 2:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 20:35 [PATCH v8 0/8] Device Tree Overlays - 8th time's the charm Pantelis Antoniou
[not found] ` <1414528565-10907-1-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-10-28 20:35 ` [PATCH v8 1/8] OF: Introduce DT overlay support. (v2) Pantelis Antoniou
[not found] ` <1414528565-10907-2-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-11-13 23:36 ` Grant Likely
[not found] ` <20141113233618.1C378C40B52-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-17 14:35 ` Pantelis Antoniou
[not found] ` <3DA4B86C-C294-400D-8D03-D850B940CF7B-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-11-17 22:54 ` Grant Likely
2014-10-28 20:36 ` [PATCH v8 4/8] OF: platform: Add OF notifier handler Pantelis Antoniou
[not found] ` <1414528565-10907-5-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-11-13 23:29 ` Grant Likely
[not found] ` <20141113232944.1F136C40B52-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-14 15:13 ` Pantelis Antoniou
2014-10-28 20:35 ` [PATCH v8 2/8] OF: selftest: Add overlay self-test support. (v2) Pantelis Antoniou
2014-10-28 20:36 ` [PATCH v8 3/8] OF: DT-Overlay configfs interface (v2) Pantelis Antoniou
[not found] ` <1414528565-10907-4-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-11-25 10:28 ` Grant Likely
2014-11-25 14:50 ` Pantelis Antoniou
[not found] ` <773D4828-4530-46E7-8786-1DBA490C36EB-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2014-11-26 12:49 ` Grant Likely
2014-10-28 20:36 ` [PATCH v8 5/8] of: i2c: Export single device registration method Pantelis Antoniou
[not found] ` <1414528565-10907-6-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-11-21 1:46 ` Grant Likely
[not found] ` <20141121014631.C86D5C413E8-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-23 16:22 ` Wolfram Sang
2014-10-28 20:36 ` [PATCH v8 6/8] OF: i2c: Add OF notifier handler Pantelis Antoniou
[not found] ` <1414528565-10907-7-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-11-21 1:53 ` Grant Likely
2014-11-21 2:03 ` Guenter Roeck [this message]
[not found] ` <546E9D75.3000208-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-11-21 15:08 ` Grant Likely
[not found] ` <20141121150837.20DC4C40D85-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-21 15:11 ` Pantelis Antoniou
2014-11-23 16:23 ` Wolfram Sang
2014-10-28 20:36 ` [PATCH v8 7/8] of: spi: Export single device registration method and accessors Pantelis Antoniou
2014-10-29 7:44 ` Alexander Sverdlin
[not found] ` <54509AE2.80404-OYasijW0DpE@public.gmane.org>
2014-10-29 8:19 ` Pantelis Antoniou
2014-10-28 20:36 ` [PATCH v8 8/8] OF: spi: Add OF notifier handler Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546E9D75.3000208@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Alison_Chaiken@mentor.com \
--cc=alexander.sverdlin@nsn.com \
--cc=broonie@kernel.org \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinh.linux@gmail.com \
--cc=dirk.behme@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=ioan.nicu.ext@nsn.com \
--cc=jlbec@evilplan.org \
--cc=jluebbe@lasnet.de \
--cc=koen@dominion.thruhere.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matt.porter@linaro.org \
--cc=mbohan@codeaurora.org \
--cc=monstr@monstr.eu \
--cc=mranostay@gmail.com \
--cc=ms@mycable.de \
--cc=pantelis.antoniou@konsulko.com \
--cc=robherring2@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).