From: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Javier Martinez Canillas
<javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT
Date: Thu, 20 Aug 2015 23:45:09 +0200 [thread overview]
Message-ID: <55D64A65.7030905@osg.samsung.com> (raw)
In-Reply-To: <20150820210822.GH74600-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On 08/20/2015 11:08 PM, Brian Norris wrote:
> On Thu, Aug 20, 2015 at 11:36:34AM -0700, Mark Brown wrote:
>> On Thu, Aug 20, 2015 at 09:07:31AM +0200, Javier Martinez Canillas wrote:
>>> From: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
>>>
>>> An SPI driver that supports both OF and legacy platforms, will have
>>> both an OF and SPI ID table. This means that when built as a module,
>>> the aliases will be filled from both tables, e.g:
>>
>> This is tagged as something that can't be applied but you've not
>> explained why it can't be applied or what comments might be useful :(
>
As Brian pointed out it was in the cover letter so I thought it would
just be duplicated information. But you are right, I should had added
a brief note as well just to make the patch self contained.
> I believe that's mostly addressed in the cover letter [1].
>
> Patch #18 changes the logic of spi_uevent() to report an OF modalias
> if the device was registered using OF. But this patch is included in
> the series only as an RFC for illustration purposes since changing
> that without first applying all the other patches in this series, will
> break module autoloading for the drivers of devices registered using
> OF but that lacks an of_match_table. I'll repost patch #18 once all
> the patches in this series have landed.
>
> IOW, it's labeled as such mostly for safety, since it has quite a few
> distributed dependencies.
>
That's correct. If is merged before the other patches, module autoloading
will break for the drivers that are relying on the current behavior.
I just added for illustration purposes to show what was the plan.
> Brian
>
> [1] https://lkml.org/lkml/2015/8/20/109
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-20 21:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 7:07 [PATCH 00/18] Export SPI and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT Javier Martinez Canillas
[not found] ` <1440054451-1223-19-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-20 18:36 ` Mark Brown
[not found] ` <20150820183634.GN12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-20 21:08 ` Brian Norris
[not found] ` <20150820210822.GH74600-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-08-20 21:45 ` Javier Martinez Canillas [this message]
[not found] ` <55D64A65.7030905-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-20 23:25 ` Mark Brown
2015-08-20 23:47 ` Javier Martinez Canillas
[not found] ` <55D666F4.2080801-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-21 17:29 ` Mark Brown
[not found] ` <20150821172931.GK12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-24 8:00 ` Javier Martinez Canillas
2015-08-20 21:11 ` [PATCH 00/18] Export SPI and OF module aliases in missing drivers Brian Norris
2015-08-20 21:50 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D64A65.7030905@osg.samsung.com \
--to=javier-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).