From: Heiner Kallweit <hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/3] spi: fsl-(e)spi: migrate to using devm_ functions to simplify cleanup
Date: Tue, 25 Aug 2015 22:14:46 +0200 [thread overview]
Message-ID: <55DCCCB6.2060805@gmail.com> (raw)
In-Reply-To: <20150825174349.GE12878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Am 25.08.2015 um 19:43 schrieb Mark Brown:
> On Sun, Aug 23, 2015 at 02:20:58PM +0200, Heiner Kallweit wrote:
>
>> /* Register for SPI Interrupt */
>> - ret = request_irq(mpc8xxx_spi->irq, fsl_espi_irq,
>> + ret = devm_request_irq(dev, mpc8xxx_spi->irq, fsl_espi_irq,
>> 0, "fsl_espi", mpc8xxx_spi);
>
> Also, are you *sure* this conversion is safe? One trick with interrupts
> is that the interrupt could still fire after the device removal function
> runs since devm_ dealloacation runs after that.
After each transfer interrupts are disabled (at end of fsl_espi_bufs).
Therefore I *think* it's safe.
And as resources are freed in reverse order (irq first), shouldn't this be enough
to be on the safe side?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-08-25 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 12:20 [PATCH 1/3] spi: fsl-(e)spi: migrate to using devm_ functions to simplify cleanup Heiner Kallweit
[not found] ` <55D9BAAA.7060401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-25 17:26 ` Mark Brown
[not found] ` <20150825172644.GD12878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-25 19:54 ` Heiner Kallweit
2015-08-25 17:43 ` Mark Brown
[not found] ` <20150825174349.GE12878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-25 20:14 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DCCCB6.2060805@gmail.com \
--to=hkallweit1-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).