From: Jiada Wang <jiada_wang@mentor.com>
To: "Mark Brown vladimir_zapolskiy@mentor.com" <broonie@kernel.org>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] spi: imx: support to set watermark level via DTS
Date: Fri, 6 Jan 2017 01:00:00 -0800 [thread overview]
Message-ID: <586F5C90.5070108@mentor.com> (raw)
In-Reply-To: <20170105175854.gj5xr5drk5tddzyz@sirena.org.uk>
Hello Mark and Vladimir
On 01/05/2017 09:58 AM, Mark Brown wrote:
> On Thu, Jan 05, 2017 at 03:10:15PM +0900, Jiada Wang wrote:
>
>> Previously watermark level is configured to fifosize/2,
>> DMA mode can be used only when transfer length can be divided
>> by 'watermark level * bpw', which makes DMA mode not practical.
>> This patch adds new DTS property 'dma-wml', user can configure
>> DMA watermark level, by specify 'dma-wml' in corresponding ecspi
>> node.
> Doesn't this just move the problem around a bit - can we not have the
> driver figure out a more sensible watermark for each transfer rather
> than fixing one in the DT?
I would like to submit another version of patch to adjust watermark level
based on transfer length. to use largest number (< fifosize / 2 ) which
can divide
(transfer_length / bytes_per_work).
Thanks,
Jiada
prev parent reply other threads:[~2017-01-06 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 6:10 [PATCH 1/1] spi: imx: support to set watermark level via DTS Jiada Wang
[not found] ` <20170105061015.7816-1-jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2017-01-05 12:48 ` Vladimir Zapolskiy
2017-01-05 17:58 ` Mark Brown
2017-01-06 9:00 ` Jiada Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586F5C90.5070108@mentor.com \
--to=jiada_wang@mentor.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).