From: Jiada Wang <jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
To: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Applied "spi: imx: dynamic burst length adjust for PIO mode" to the spi tree
Date: Fri, 30 Jun 2017 07:55:55 -0700 [thread overview]
Message-ID: <5956667B.6040903@mentor.com> (raw)
In-Reply-To: <20170630121433.piznjqtmhy35zty6-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Hello Sascha
On 06/30/2017 05:14 AM, Sascha Hauer wrote:
> Hi Mark,
>
> On Fri, Jun 30, 2017 at 01:00:22PM +0100, Mark Brown wrote:
>> The patch
>>
>> spi: imx: dynamic burst length adjust for PIO mode
>>
>> has been applied to the spi tree at
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
> Argh, I wasn't fast enough. I just ran spi-loopback-test.ko with this
> patch and it doesn't work properly.
>
>> + if (spi_imx->count == spi_imx->remainder) {
>> + ctrl = readl(spi_imx->base + MX51_ECSPI_CTRL);
>> + ctrl&= ~MX51_ECSPI_CTRL_BL_MASK;
>> + if (spi_imx->count> MX51_ECSPI_CTRL_MAX_BURST) {
>> + spi_imx->remainder = spi_imx->count %
>> + MX51_ECSPI_CTRL_MAX_BURST;
>> + val = MX51_ECSPI_CTRL_MAX_BURST;
> This is wrong. MX51_ECSPI_CTRL_MAX_BURST contains the burst length in
> bytes, but the register 'val' is written to takes the burst length in
> bits - 1, so this should be:
>
> val = MX51_ECSPI_CTRL_MAX_BURST * 8 - 1;
>
> instead.
Thanks for pointing this out,
I will submit a fix patch.
Thanks,
Jiada
> Sascha
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-30 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 8:34 [PATCH linux-next v4 1/1] spi: imx: dynamic burst length adjust for PIO mode Jiada Wang
2017-06-30 12:00 ` Applied "spi: imx: dynamic burst length adjust for PIO mode" to the spi tree Mark Brown
2017-06-30 12:14 ` Sascha Hauer
[not found] ` <20170630121433.piznjqtmhy35zty6-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-06-30 14:55 ` Jiada Wang [this message]
2017-07-03 15:12 ` Mark Brown
[not found] ` <20170613083402.22324-1-jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2017-07-07 12:53 ` Mark Brown
2017-07-07 12:58 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2017-08-10 4:50 [PATCH linux-next v5 1/1] spi: imx: dynamic burst length adjust for PIO mode Jiada Wang
2017-08-17 17:14 ` Applied "spi: imx: dynamic burst length adjust for PIO mode" to the spi tree Mark Brown
2017-05-01 10:31 [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust for PIO mode jiada_wang-nmGgyN9QBj3QT0dZR+AlfA
2017-05-15 8:04 ` Applied "spi: imx: dynamic burst length adjust for PIO mode" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5956667B.6040903@mentor.com \
--to=jiada_wang-nmggyn9qbj3qt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).