linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] [SPI][POWERPC] spi_mpc83xx: in "QE mode" spiclk is sysclk/2
Date: Thu, 2 Aug 2007 10:19:17 -0500	[thread overview]
Message-ID: <59836CD3-C46E-4B51-8FFE-5F40107CAA85@kernel.crashing.org> (raw)
In-Reply-To: <20070802142641.GA6309-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>


On Aug 2, 2007, at 9:26 AM, Anton Vorontsov wrote:

> For MPC8349E input to SPIBRG is SYSCLK, but it's SYSCLK/2 for
> MPC8323E (running in so-called "QE mode").

QE mode or the SPI in QE running in CPU mode?

- k

>
> This fixes clocking issues I've noticed recently.
>
> Probably someday mpc83xx_spi->sysclk should be renamed to
> mpc83xx_spi->spiclk to be less confusing.
>
> Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
> ---
>  drivers/spi/spi_mpc83xx.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
> index 0c16a2b..55230f7 100644
> --- a/drivers/spi/spi_mpc83xx.c
> +++ b/drivers/spi/spi_mpc83xx.c
> @@ -429,13 +429,17 @@ static int __init mpc83xx_spi_probe(struct  
> platform_device *dev)
>  	mpc83xx_spi->bitbang.chipselect = mpc83xx_spi_chipselect;
>  	mpc83xx_spi->bitbang.setup_transfer = mpc83xx_spi_setup_transfer;
>  	mpc83xx_spi->bitbang.txrx_bufs = mpc83xx_spi_bufs;
> -	mpc83xx_spi->sysclk = pdata->sysclk;
>  	mpc83xx_spi->activate_cs = pdata->activate_cs;
>  	mpc83xx_spi->deactivate_cs = pdata->deactivate_cs;
>  	mpc83xx_spi->qe_mode = pdata->qe_mode;
>  	mpc83xx_spi->get_rx = mpc83xx_spi_rx_buf_u8;
>  	mpc83xx_spi->get_tx = mpc83xx_spi_tx_buf_u8;
>
> +	if (mpc83xx_spi->qe_mode)
> +		mpc83xx_spi->sysclk = pdata->sysclk / 2;
> +	else
> +		mpc83xx_spi->sysclk = pdata->sysclk;
> +
>  	mpc83xx_spi->rx_shift = 0;
>  	mpc83xx_spi->tx_shift = 0;
>  	if (mpc83xx_spi->qe_mode) {
> -- 
> 1.5.0.6
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-02 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 14:26 Anton Vorontsov
     [not found] ` <20070802142641.GA6309-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-08-02 15:19   ` Kumar Gala [this message]
     [not found]     ` <59836CD3-C46E-4B51-8FFE-5F40107CAA85-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2007-08-02 15:27       ` Anton Vorontsov
2007-08-02 21:47   ` David Brownell
     [not found]     ` <200708021447.22028.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-08-03  9:29       ` Kumar Gala
     [not found]         ` <595EE3AF-CDD6-4260-83D9-A3FA3EA1DF95-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2007-08-06 12:04           ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59836CD3-C46E-4B51-8FFE-5F40107CAA85@kernel.crashing.org \
    --to=galak-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
    --cc=avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --subject='Re: [PATCH] [SPI][POWERPC] spi_mpc83xx: in "QE mode" spiclk is sysclk/2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).