From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Dan Murphy <dmurphy@ti.com>,
linux-leds <linux-leds@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Benson Leung <bleung@chromium.org>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Lubomir Rintel <lkundrak@v3.sk>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: misc: add support for both property names cmd-gpios and cmd-gpio
Date: Thu, 15 Oct 2020 15:59:28 +0800 [thread overview]
Message-ID: <5df45c92-9a2c-82d4-491a-ec869f347665@huawei.com> (raw)
In-Reply-To: <CAMuHMdX6qLJbk=ik1CoqbycrLSr+vMwzpY6esnKRpXsTxaiSAw@mail.gmail.com>
On 2020/10/15 15:01, Geert Uytterhoeven wrote:
> Hi Zhen,
>
> Thanks for your patch!
>
> On Thu, Oct 15, 2020 at 6:52 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>> The definition "gpio_suffixes[] = { "gpios", "gpio" }" shows that both
>> property names "cmd-gpios" and "cmd-gpio" are supported. But currently
>> only "cmd-gpios" is allowed in this yaml, and the name used in
>> mmp2-olpc-xo-1-75.dts is cmd-gpio. As a result, the following errors is
>> reported.
>>
>> slave: 'cmd-gpios' is a required property
>> slave: 'cmd-gpio' does not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 14 ++++++++++----
>> 1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> index b3c45c046ba5e37..dd549380a085709 100644
>> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> @@ -24,15 +24,21 @@ properties:
>> compatible:
>> const: olpc,xo1.75-ec
>>
>> - cmd-gpios:
>> + spi-cpha: true
>> +
>> +patternProperties:
>> + "^cmd-gpio[s]?$":
>> description: GPIO uspecifier of the CMD pin
>> maxItems: 1
>
> In general, the *-gpio form is deprecated. So why complicate the DT
> bindings by adding support for deprecated properties?
I just don't know this information. So this patch can be ignored.
>
> 1. Explicitly allowing deprecated properties means new users may be
> added,
> 2. Once all in-tree DTS files are converted, the warnings will be gone
> anyway,
> 3. Out-of-tree DTB will still work, as it's very unlikely support for
> the "gpio" suffix can/will be dropped anytime soon,
> 4. If anyone runs the validator on out-of-tree DTS files, the most
> probable intention is to fix any detected issues anyway, and the
> files can be updated, too,
> 5. If any out-of-tree code or tooling relies on the *-gpio form, it
> may already be broken.
>
>> - spi-cpha: true
>> -
>> required:
>> - compatible
>> - - cmd-gpios
>> +
>> +oneOf:
>> + - required:
>> + - cmd-gpio
>> + - required:
>> + - cmd-gpios
>>
>> additionalProperties: false
>
> Gr{oetje,eeting}s,
>
> Geert
>
prev parent reply other threads:[~2020-10-15 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 4:44 [PATCH v2 0/1] fix all errors except one reported by dt_binding_check Zhen Lei
2020-10-15 4:44 ` [PATCH v2 1/1] dt-bindings: misc: add support for both property names cmd-gpios and cmd-gpio Zhen Lei
2020-10-15 7:01 ` Geert Uytterhoeven
2020-10-15 7:59 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5df45c92-9a2c-82d4-491a-ec869f347665@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=enric.balletbo@collabora.com \
--cc=geert@linux-m68k.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).