From: Linus Walleij <linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH v3] spi: driver for the Synopsys DesignWare SPI controller
Date: Thu, 4 Jun 2009 10:30:23 +0200 [thread overview]
Message-ID: <63386a3d0906040130h322028d3ocbd3e31719bac8c9@mail.gmail.com> (raw)
In-Reply-To: <1244087418-10889-1-git-send-email-baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2009/6/4 Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>:
> +static int __devexit designware_spi_remove(struct platform_device *dev)
> +{
> + struct designware_spi *dwspi;
> + struct spi_master *master;
> +
> + master = platform_get_drvdata(dev);
> + dwspi = spi_master_get_devdata(master);
> +
> + free_irq(dwspi->irq, dwspi);
> + iounmap(dwspi->regs);
release_mem_region()?
> + destroy_workqueue(dwspi->workqueue);
> + tasklet_kill(&dwspi->pump_transfers);
> + platform_set_drvdata(dev, 0);
> + spi_master_put(master);
> +
> + return 0;
> +}
Then it's good :-)
Linus
------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
next prev parent reply other threads:[~2009-06-04 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 3:50 [PATCH v3] spi: driver for the Synopsys DesignWare SPI controller Baruch Siach
[not found] ` <1244087418-10889-1-git-send-email-baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2009-06-04 8:30 ` Linus Walleij [this message]
[not found] ` <63386a3d0906040130h322028d3ocbd3e31719bac8c9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-05 2:58 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63386a3d0906040130h322028d3ocbd3e31719bac8c9@mail.gmail.com \
--to=linus.ml.walleij-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).