Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Lee Jones <lee.jones@linaro.org>, broonie@kernel.org
Cc: Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	Beniamino Galvani <b.galvani@gmail.com>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc'
Date: Tue, 21 Jul 2020 10:00:59 +0200
Message-ID: <6655a485-fc5a-690e-b752-59f12d545cc0@baylibre.com> (raw)
In-Reply-To: <20200717135424.2442271-6-lee.jones@linaro.org>

On 17/07/2020 15:54, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc'
> 
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Beniamino Galvani <b.galvani@gmail.com>
> Cc: linux-amlogic@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/spi/spi-meson-spifc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c
> index c7b0399802913..8eca6f24cb799 100644
> --- a/drivers/spi/spi-meson-spifc.c
> +++ b/drivers/spi/spi-meson-spifc.c
> @@ -70,7 +70,7 @@
>   * @master:	the SPI master
>   * @regmap:	regmap for device registers
>   * @clk:	input clock of the built-in baud rate generator
> - * @device:	the device structure
> + * @dev:	the device structure
>   */
>  struct meson_spifc {
>  	struct spi_master *master;
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 13:54 [PATCH v2 00/14] Rid W=1 warnings in SPI Lee Jones
2020-07-17 13:54 ` [PATCH v2 01/14] spi: spi-loopback-test: Fix formatting issues in function header blocks Lee Jones
2020-07-17 13:54 ` [PATCH v2 02/14] spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-17 13:54 ` [PATCH v2 03/14] spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages Lee Jones
2020-07-17 13:54 ` [PATCH v2 04/14] spi: spi-ep93xx: Fix API slippage Lee Jones
2020-07-17 13:54 ` [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Lee Jones
2020-07-21  8:00   ` Neil Armstrong [this message]
2020-07-17 13:54 ` [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Lee Jones
2020-07-21  8:01   ` Neil Armstrong
2020-07-17 13:54 ` [PATCH v2 07/14] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data' Lee Jones
2020-07-17 13:54 ` [PATCH v2 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs Lee Jones
2020-07-17 13:54 ` [PATCH v2 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Lee Jones
2020-07-17 13:54 ` [PATCH v2 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc Lee Jones
2020-07-17 13:54 ` [PATCH v2 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data' Lee Jones
2020-07-17 13:54 ` [PATCH v2 12/14] spi: spi-at91-usart: Remove unused OF table 'struct of_device_id' Lee Jones
2020-07-17 14:02   ` Alexandre Belloni
2020-07-17 13:54 ` [PATCH v2 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones
2020-07-17 13:54 ` [PATCH v2 14/14] spi: spi-amd: " Lee Jones
2020-07-20 11:12 ` [PATCH v2 00/14] Rid W=1 warnings in SPI Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6655a485-fc5a-690e-b752-59f12d545cc0@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=b.galvani@gmail.com \
    --cc=broonie@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git