From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Walle Subject: Re: [PATCH] spi: spi-fsl-dspi: fix DMA mapping Date: Tue, 10 Mar 2020 15:12:45 +0100 Message-ID: <76923af394f334337a3cac125c270087@walle.cc> References: <20200310073313.21277-1-michael@walle.cc> <4beb5200a76f2d817be7276444543de4@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-spi@vger.kernel.org, lkml , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Sumit Semwal , Mark Brown , Vladimir Oltean To: Vladimir Oltean Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org Am 2020-03-10 14:02, schrieb Vladimir Oltean: > On Tue, 10 Mar 2020 at 10:12, Michael Walle wrote: >> >> Am 2020-03-10 08:40, schrieb Michael Walle: >> > Am 2020-03-10 08:33, schrieb Michael Walle: >> >> Use the correct device to request the DMA mapping. Otherwise the IOMMU >> >> doesn't get the mapping and it will generate a page fault. >> >> >> >> The error messages look like: >> >> [ 3.008452] arm-smmu 5000000.iommu: Unhandled context fault: >> >> fsr=0x402, iova=0xf9800000, fsynr=0x3f0022, cbfrsynra=0x828, cb=8 >> >> [ 3.020123] arm-smmu 5000000.iommu: Unhandled context fault: >> >> fsr=0x402, iova=0xf9800000, fsynr=0x3f0022, cbfrsynra=0x828, cb=8 >> >> >> >> This was tested on a custom board with a LS1028A SoC. >> > >> > Oh fu.. please disregard this patch. DMA mapping still isn't working. >> > Somehow I missed that the transfer mode was turned back to its default >> > XSPI mode. >> >> Damn. I need more coffee.. this patch IS working. Only the first probe >> fails due to EPROBE_DEFER. >> >> [ 2.539706] fsl-dspi 2120000.spi: rx dma channel not available >> (-517) >> [ 2.546200] fsl-dspi 2120000.spi: can't get dma channels >> [ 3.622774] spi-nor spi1.0: w25q128fw (16384 Kbytes) >> >> -michael > > I'm testing LS1028A with IOMMU_DEFAULT_PASSTHROUGH=y and I didn't have > time to change my setup now. I've also sent a v3 to my patch series > which is going to conflict with this one, sorry. No worries, its easy enough to rebase. > I would have picked > your patch up with my series but I didn't have the right environment > to test it. I'll resend a v2 once your series is working. -michael