From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx Date: Tue, 25 Sep 2007 23:00:38 -0500 Message-ID: <7881139C-EEF1-41DC-AB0F-115632E892B8@kernel.crashing.org> References: <20070925143126.GA30013@localhost.localdomain> <20070925143531.GG5323@localhost.localdomain> <16E78F0E-B57B-4084-887E-5D2F9C1D0331@kernel.crashing.org> <20070925151819.GA6757@localhost.localdomain> <20070925165845.40B0E2397FB@adsl-69-226-248-13.dsl.pltn13.pacbell.net> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: David Brownell Return-path: In-Reply-To: <20070925165845.40B0E2397FB-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sep 25, 2007, at 11:58 AM, David Brownell wrote: >>>> - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL >>>> + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL >>> >>> Should that really be just PPC_83xx || QUICC_ENGINE? >> >> Well, I thought about that. By now I'm unsure if every QE >> implementation will be compatible with further ones. > > How many other QE implementations exist? Is that sort of > gratuitous breakage something Freescale makes a habit of? We try not to, but HW people are know to do evil things to keep us software guys employed. >> So far >> I've tested this driver on MPC8323 and MPC8568. If we'll see >> more and more compatible QE SPI controllers, of course we >> may just do || QUICC_ENGINE. >> >> PPC_83xx || PPC_85xx >> PPC_83xx || QUICC_ENGINE >> >> Today first option saves us four bytes. ;-) > > It'd be good if someone would look at the relevant docs. > > I'll wait for a PPC signoff before I forward this for > merge with SPI stuff... I'm still in favor of making it PPC_83xx || QUICC_ENGINE. So if when we have 87xx with QUICC_ENGINE we don't have to tweak it again, but its a minor thing. - k ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/