From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor.Dooley@microchip.com, Nagasuresh.Relli@microchip.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Valentina.FernandezAlanis@microchip.com
Subject: Re: [PATCH v3 2/4] spi: dt-binding: add coreqspi as a fallback for mpfs-qspi
Date: Fri, 5 Aug 2022 10:47:39 +0200 [thread overview]
Message-ID: <7c9f0d96-2882-964a-cd1f-916ddb3f0410@linaro.org> (raw)
In-Reply-To: <c2256f4b-95cd-aa9b-f839-8f54e2ba8d5e@microchip.com>
On 05/08/2022 10:44, Conor.Dooley@microchip.com wrote:
>> 1. It is redundant. I did not look too much at the driver, but none of
>> the of_device_id entries have some driver data to differentiate,
>> therefore - for the driver - the devices are identical. If they are
>> identical and according to binding compatible, use less code and just
>> one compatible.
>
> Right. Then the binding is correct and the driver should only bind
> against "microchip,coreqspi-rtl-v2".
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-05 8:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 5:30 [PATCH v3 0/4] Add support for Microchip QSPI controller Naga Sureshkumar Relli
2022-08-05 5:30 ` [PATCH v3 1/4] spi: dt-binding: document microchip coreQSPI Naga Sureshkumar Relli
2022-08-05 6:46 ` Krzysztof Kozlowski
2022-08-05 5:30 ` [PATCH v3 2/4] spi: dt-binding: add coreqspi as a fallback for mpfs-qspi Naga Sureshkumar Relli
2022-08-05 6:47 ` Krzysztof Kozlowski
2022-08-05 6:49 ` Krzysztof Kozlowski
2022-08-05 7:34 ` Conor.Dooley
2022-08-05 8:12 ` Krzysztof Kozlowski
2022-08-05 8:44 ` Conor.Dooley
2022-08-05 8:47 ` Krzysztof Kozlowski [this message]
2022-08-05 14:14 ` Rob Herring
2022-08-05 5:30 ` [PATCH v3 3/4] spi: microchip-core-qspi: Add support for microchip fpga qspi controllers Naga Sureshkumar Relli
2022-08-05 6:50 ` Krzysztof Kozlowski
2022-08-05 5:30 ` [PATCH v3 4/4] MAINTAINERS: add qspi to Polarfire SoC entry Naga Sureshkumar Relli
2022-08-05 6:50 ` Krzysztof Kozlowski
2022-08-05 11:04 ` Mark Brown
2022-08-05 11:05 ` Mark Brown
2022-08-05 12:07 ` Conor.Dooley
2022-08-05 12:11 ` Mark Brown
2022-08-05 9:14 ` [PATCH v3 0/4] Add support for Microchip QSPI controller Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c9f0d96-2882-964a-cd1f-916ddb3f0410@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Conor.Dooley@microchip.com \
--cc=Nagasuresh.Relli@microchip.com \
--cc=Valentina.FernandezAlanis@microchip.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).