linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Qing Zhang <zhangqing@loongson.cn>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-spi@vger.kernel.org, "Huacai Chen" <chenhc@lemote.com>,
	devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>
Subject: Re: [PATCH 2/3] MIPS: Loongson64: DTS: Add SPI support to LS3A
Date: Mon, 23 Nov 2020 18:48:52 +0800	[thread overview]
Message-ID: <7e878d14-37b2-769e-400a-548a846943fe@flygoat.com> (raw)
In-Reply-To: <1606123148-315-2-git-send-email-zhangqing@loongson.cn>


在 2020/11/23 17:19, Qing Zhang 写道:
> The LS3A SPI module is now supported, enable it.
>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
>   arch/mips/boot/dts/loongson/loongson64c-package.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/mips/boot/dts/loongson/loongson64c-package.dtsi b/arch/mips/boot/dts/loongson/loongson64c-package.dtsi
> index 5bb876a..2025c5a 100644
> --- a/arch/mips/boot/dts/loongson/loongson64c-package.dtsi
> +++ b/arch/mips/boot/dts/loongson/loongson64c-package.dtsi
> @@ -60,5 +60,12 @@
>   			interrupt-parent = <&liointc>;
>   			no-loopback-test;
>   		};
> +
> +                spi: spi@1fe00220 {
> +                        compatible = "loongson,loongson-spi";

You have to add dt schema document..

Also I'd sugguest you to name it as loongson,pci-spi to avoid collision.

Loongson-1 MCUs do have MMIO SPI controller with similiar register layout.

Thanks

- Jiaxun

> +                        reg=<0 0x1fe00220 0x11>;
> +                        #address-cells = <1>;
> +                        #size-cells = <0>;
> +               };
>   	};
>   };

  reply	other threads:[~2020-11-23 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23  9:19 [PATCH 1/3] spi: Loongson: Add Loongson 3A+7A SPI controller driver support Qing Zhang
2020-11-23  9:19 ` [PATCH 2/3] MIPS: Loongson64: DTS: Add SPI support to LS3A Qing Zhang
2020-11-23 10:48   ` Jiaxun Yang [this message]
2020-11-23  9:19 ` [PATCH 3/3] MIPS: Loongson: Enable Loongson SPI in loongson3_defconfig Qing Zhang
2020-11-23 13:10 ` [PATCH 1/3] spi: Loongson: Add Loongson 3A+7A SPI controller driver support Mark Brown
2020-11-24  1:54   ` zhangqing
2020-11-26 11:58 ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e878d14-37b2-769e-400a-548a846943fe@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=broonie@kernel.org \
    --cc=chenhc@lemote.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=f4bug@amsat.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=zhangqing@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).