From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
"Pavel Machek" <pavel@ucw.cz>,
linux-leds <linux-leds@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Benson Leung <bleung@chromium.org>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Lubomir Rintel <lkundrak@v3.sk>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led
Date: Wed, 14 Oct 2020 09:08:16 +0800 [thread overview]
Message-ID: <82761c4f-6533-9b63-daa4-146a58816f5b@huawei.com> (raw)
In-Reply-To: <1565f22c-7be9-e771-7def-afbb28ec07a7@ti.com>
On 2020/10/14 0:17, Dan Murphy wrote:
> Zhen
>
> On 10/13/20 11:08 AM, Zhen Lei wrote:
>> The color value of multi-led is fixed to "const: 8 #LED_COLOR_ID_MULTI",
>> which is required by leds-class-multicolor.yaml.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
>> index 58e974793a7976b..cd877e817ad1a1c 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
>> @@ -197,7 +197,7 @@ examples:
>> #address-cells = <1>;
>> #size-cells = <0>;
>> reg = <0x2>;
>> - color = <LED_COLOR_ID_RGB>;
>> + color = <LED_COLOR_ID_MULTI>;
>> function = LED_FUNCTION_STANDBY;
>> linux,default-trigger = "heartbeat";
>>
>
> This is not correct. ID_RGB is the correct variable here.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=3d93edc77515c6f51fa9bbbe2185e2ec32bad024
>
> Correct fix is to update the leds-class-multicolor.yaml
OK
>
> Dan
>
>
> .
>
next prev parent reply other threads:[~2020-10-14 1:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 16:08 [PATCH 0/6] fix all errors except one reported by dt_binding_check Zhen Lei
2020-10-13 16:08 ` [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led Zhen Lei
2020-10-13 16:17 ` Dan Murphy
2020-10-13 17:04 ` Pavel Machek
2020-10-14 1:08 ` Leizhen (ThunderTown) [this message]
2020-10-13 16:08 ` [PATCH 2/6] dt-bindings: mfd: google,cros-ec: explicitly allow additional properties Zhen Lei
2020-10-13 17:53 ` Dan Murphy
2020-10-14 1:52 ` Leizhen (ThunderTown)
2020-10-14 13:38 ` Rob Herring
2020-10-15 6:55 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode Zhen Lei
2020-10-14 13:41 ` Rob Herring
2020-10-13 16:08 ` [PATCH 4/6] dt-bindings: misc: explicitly add #address-cells " Zhen Lei
2020-10-14 13:42 ` Rob Herring
2020-10-13 16:08 ` [PATCH 5/6] ARM: dts: mmp2-olpc-xo-1-75: explicitly add #address-cells=<0> " Zhen Lei
2020-10-15 9:56 ` Leizhen (ThunderTown)
2020-12-04 7:48 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio Zhen Lei
2020-10-13 17:32 ` Dan Murphy
2020-10-14 1:29 ` Leizhen (ThunderTown)
2020-10-14 13:50 ` Rob Herring
2020-10-15 3:23 ` Leizhen (ThunderTown)
2020-10-16 14:13 ` Rob Herring
2020-10-15 7:12 ` Lubomir Rintel
2020-10-15 7:32 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82761c4f-6533-9b63-daa4-146a58816f5b@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).