From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select Date: Thu, 05 Mar 2020 08:01:02 -0800 Message-ID: <84f8504924380fc6380216d03d28a2285e3d106e.camel@perches.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Mark Brown , linux-spi , LKML To: John Garry Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, 2020-03-05 at 15:53 +0000, John Garry wrote: > On 05/03/2020 15:15, Joe Perches wrote: > > commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash > > controller driver") likely inadvertently used a select statement > > with a CONFIG_ prefix, remove the prefix. > > > > Signed-off-by: Joe Perches > > It's a pity checkpatch can't pick this stuff up... You are free to write a rule and submit a patch. The grammar is pretty hard to verify from a patch fragment though. There are 2 existing nominal false positives. $ git grep 'select\b.*\bCONFIG_' -- '*/Kconfig*' drivers/edac/Kconfig: select CONFIG_ACPI_NFIT. drivers/edac/Kconfig: select CONFIG_ACPI_NFIT.