From: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
s-paulraj-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH v2] SPI DaVinci: SPI master driver for DaVinci/DA8xx
Date: Tue, 05 Jan 2010 16:46:41 -0800 [thread overview]
Message-ID: <87iqbgnjpq.fsf@deeprootsystems.com> (raw)
In-Reply-To: <fa686aa41001051641w58ae2b11w476ae2fd8ef325ed-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Grant Likely's message of "Tue\, 5 Jan 2010 17\:41\:42 -0700")
Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> writes:
> On Tue, Jan 5, 2010 at 4:46 PM, Kevin Hilman
> <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org> wrote:
>> s-paulraj-l0cyMroinI0@public.gmane.org writes:
>>
>>> From: Sandeep Paulraj <s-paulraj-l0cyMroinI0@public.gmane.org>
>>>
>>> This patch adds support for a SPI master driver for the
>>> DaVinci series of SOCs
>>>
>>> Signed-off-by: Sandeep Paulraj <s-paulraj-l0cyMroinI0@public.gmane.org>
>>> Signed-off-by: Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
>>> Signed-off-by: Philby John <pjohn-k0rHJ+Hhz/SB+jHODAdFcQ@public.gmane.org>
>>> Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj-l0cyMroinI0@public.gmane.org>
>>
>> Sandeep,
>>
>> This needs a minor refresh against current Linus tree for the Makefile
>> change.
>>
>> While doing the Makefile addition, it looks like the list is maintained in
>> alphabetical order. Please add davinci in the right order, and feel free to
>> add my signoff.
>
> Signed-of-by lines are only for patches that actually pass through
> your hands (ie. you add it yourself when you pick it up and pass it).
> It is not appropriate to add a s-o-b line for someone else.
> "Acked-by" or "Reviewed-by" should be used instead.
Understood. This driver has passed through my hands (and in front of
my eyes) in various forms many times in its development, so I figured
an s-o-b was appropriate.
That being said, for this particular version, and ack is probably more
appropriate.
Sandeep, after you refresh, please add
Acked-by: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
next prev parent reply other threads:[~2010-01-06 0:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 22:02 [PATCH v2] SPI DaVinci: SPI master driver for DaVinci/DA8xx s-paulraj-l0cyMroinI0
[not found] ` <1261000938-1897-1-git-send-email-s-paulraj-l0cyMroinI0@public.gmane.org>
2010-01-05 23:43 ` Kevin Hilman
2010-01-05 23:46 ` Kevin Hilman
[not found] ` <878wccqfmp.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-01-06 0:41 ` Grant Likely
[not found] ` <fa686aa41001051641w58ae2b11w476ae2fd8ef325ed-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-06 0:46 ` Kevin Hilman [this message]
[not found] ` <87iqbgnjpq.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-01-20 20:26 ` Grant Likely
2010-01-20 20:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqbgnjpq.fsf@deeprootsystems.com \
--to=khilman-1d3hcaltpluheniveurvkkeocmrvltnr@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=s-paulraj-l0cyMroinI0@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).