From: David Brownell <david-b@pacbell.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Cory Maccarrone <darkstar6262@gmail.com>
Cc: spi-devel-general@lists.sourceforge.net, linux-input@vger.kernel.org
Subject: Re: [spi-devel-general] [PATCH] Input: Add tsc2046 touchscreen driver
Date: Sun, 30 May 2010 14:08:13 -0700 (PDT) [thread overview]
Message-ID: <885802.70948.qm@web180316.mail.gq1.yahoo.com> (raw)
In-Reply-To: <AANLkTike4Hu6xJ52fcC9TcKaeD4hLeWxHwUvA90tc3_Q@mail.gmail.com>
--- On Sun, 5/30/10, Cory Maccarrone <darkstar6262@gmail.com> wrote:
I don't see the point in having a separate driver
for this chip ... it's just an updated ADS7846,
and the ads7846 driver has handled it for quite
a few years now, as I recall. There's no need for
second driver.
> >> This driver differs from the ADS7846 in that it
> >> uses 16-bit commands instead of 8-bit,
The reason the ads7846 code uses 8-bit messaging
is portability ... it works with SPI controllers
which don't support 16-bit words. The commands are
of necessity 16-bits. Using 16-bit words means this
driver won't run on as many systems; folk will still
need to use the ads7846 driver with tsc2046 chips..
and does not include
> temerature
> >> or voltage sensing capabilities.
Another reason not to have a separate driver: this
one is less capable (as well as less portable)
> >> additions that allow
> >> the injection of pointercal parameters from tslib through /sys.
Something the ads7846 driver could benefit from
too ... again, two drivers is counterproductive.
- Dave
next prev parent reply other threads:[~2010-05-30 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 20:39 [PATCH] Input: Add tsc2046 touchscreen driver Cory Maccarrone
[not found] ` <1260736754-374-1-git-send-email-darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-01-10 23:07 ` Cory Maccarrone
2010-03-07 17:54 ` Cory Maccarrone
2010-04-17 8:28 ` Dmitry Torokhov
2010-05-30 20:21 ` Cory Maccarrone
2010-05-30 21:08 ` David Brownell [this message]
2010-05-30 21:15 ` [spi-devel-general] " Cory Maccarrone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=885802.70948.qm@web180316.mail.gq1.yahoo.com \
--to=david-b@pacbell.net \
--cc=darkstar6262@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).