From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mike Frysinger" Subject: Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing Date: Tue, 30 Oct 2007 16:29:45 -0400 Message-ID: <8bd0f97a0710301329i8a21b22ncc9f71a81bc06543@mail.gmail.com> References: <1193735885-8202-1-git-send-email-bryan.wu@analog.com> <200710301324.07691.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Bryan Wu , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "David Brownell" Return-path: In-Reply-To: <200710301324.07691.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 10/30/07, David Brownell wrote: > And also, pay closer attention to when you may be making > changes that make device drivers work differently over > your spi_master controller driver than anyone elses ... > such platform-specific behaviors are undesirable, and when > they go against specified behavior they are also bugs. was there something that caught your eye other than the ugly udelay() you mentioned in the other thread ? -mike ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/