From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Subject: spi_set_drvdata() handling in spidev_probe() Date: Tue, 13 Oct 2009 02:32:12 -0400 Message-ID: <8bd0f97a0910122332y321138ak8294e5f152064344@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Wolfgang Ocker , David Brownell Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org i was browsing the change history of spidev when i noticed the change: aaacf4bb51b243875b203e6ff73b5047636b4efa spi: avoid spidev crash when device is removed which seems to be due to this change: 3d81252ddb10f63ae4db713d9b32faabe641b850 device create: spi: convert device_create to device_create_drvdata getting an incomplete revert with this change: a9b12619f7b6f19c871437ec24a088787a04b1de device create: misc: convert device_create_drvdata to device_create my point being is that the original code was doing the spi_set_drvdata() while holding the device_list_lock mutex while the new one is not. shouldnt the code be changed back to the state previous to 3d81252d ? -mike ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference