From: Christian Eggers <ceggers@arri.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] eeprom: at25: allow page sizes greater than 16 bit
Date: Tue, 4 Aug 2020 08:40:52 +0200 [thread overview]
Message-ID: <9183924.TykLrII94J@n95hx1g2> (raw)
In-Reply-To: <20200727111218.26926-1-ceggers@arri.de>
Ping?
On Monday, 27 July 2020, 13:12:18 CEST, Christian Eggers wrote:
> Storage technologies like FRAM have no "write pages", the whole chip can
> be written within one SPI transfer. For these chips, the page size can
> be set equal to the device size. Currently available devices are already
> bigger than 64 kiB.
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> drivers/misc/eeprom/at25.c | 2 +-
> include/linux/spi/eeprom.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index cde9a2fc1325..0e7c8dc01195 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -261,7 +261,7 @@ static int at25_fw_to_chip(struct device *dev, struct
> spi_eeprom *chip)
>
> if (device_property_read_u32(dev, "pagesize", &val) == 0 ||
> device_property_read_u32(dev, "at25,page-size", &val) == 0) {
> - chip->page_size = (u16)val;
> + chip->page_size = val;
> } else {
> dev_err(dev, "Error: missing \"pagesize\" property\n");
> return -ENODEV;
> diff --git a/include/linux/spi/eeprom.h b/include/linux/spi/eeprom.h
> index aceccf9c71fb..1cca3dd5a748 100644
> --- a/include/linux/spi/eeprom.h
> +++ b/include/linux/spi/eeprom.h
> @@ -14,7 +14,7 @@
> struct spi_eeprom {
> u32 byte_len;
> char name[10];
> - u16 page_size; /* for writes */
> + u32 page_size; /* for writes */
> u16 flags;
> #define EE_ADDR1 0x0001 /* 8 bit addrs */
> #define EE_ADDR2 0x0002 /* 16 bit addrs */
next prev parent reply other threads:[~2020-08-04 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 11:12 [PATCH] eeprom: at25: allow page sizes greater than 16 bit Christian Eggers
2020-08-04 6:40 ` Christian Eggers [this message]
2020-08-04 7:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9183924.TykLrII94J@n95hx1g2 \
--to=ceggers@arri.de \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).