linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][14/37] Clean up duplicate includes in drivers/spi/
@ 2007-07-21 15:02 Jesper Juhl
       [not found] ` <200707211702.56466.jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2007-07-21 15:02 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: David Brownell, Jesper Juhl, Aubrey Li,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	Andrew Morton, Nicolas Pitre

Hi,

This patch cleans up duplicate includes in
	drivers/spi/


Signed-off-by: Jesper Juhl <jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---

diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
index e51311b..16bf66b 100644
--- a/drivers/spi/pxa2xx_spi.c
+++ b/drivers/spi/pxa2xx_spi.c
@@ -26,7 +26,6 @@
 #include <linux/dma-mapping.h>
 #include <linux/spi/spi.h>
 #include <linux/workqueue.h>
-#include <linux/errno.h>
 #include <linux/delay.h>
 
 #include <asm/io.h>
diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
index 48587c2..88362b4 100644
--- a/drivers/spi/spi_bfin5xx.c
+++ b/drivers/spi/spi_bfin5xx.c
@@ -39,7 +39,6 @@
 #include <linux/dma-mapping.h>
 #include <linux/spi/spi.h>
 #include <linux/workqueue.h>
-#include <linux/errno.h>
 #include <linux/delay.h>
 
 #include <asm/io.h>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][14/37] Clean up duplicate includes in drivers/spi/
       [not found] ` <200707211702.56466.jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2007-07-21 18:24   ` David Brownell
       [not found]     ` <200707211124.53195.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2007-07-21 18:24 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: David Brownell, Linux Kernel Mailing List, Aubrey Li,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	Andrew Morton, Nicolas Pitre

On Saturday 21 July 2007, Jesper Juhl wrote:
> Hi,
> 
> This patch cleans up duplicate includes in
> 	drivers/spi/
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

ACK ... although, on general principles I suspect there are more
needless includes to remove, these are just especially obvious.  :)


> ---
> 
> diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
> index e51311b..16bf66b 100644
> --- a/drivers/spi/pxa2xx_spi.c
> +++ b/drivers/spi/pxa2xx_spi.c
> @@ -26,7 +26,6 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/spi/spi.h>
>  #include <linux/workqueue.h>
> -#include <linux/errno.h>
>  #include <linux/delay.h>
>  
>  #include <asm/io.h>
> diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
> index 48587c2..88362b4 100644
> --- a/drivers/spi/spi_bfin5xx.c
> +++ b/drivers/spi/spi_bfin5xx.c
> @@ -39,7 +39,6 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/spi/spi.h>
>  #include <linux/workqueue.h>
> -#include <linux/errno.h>
>  #include <linux/delay.h>
>  
>  #include <asm/io.h>
> 



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][14/37] Clean up duplicate includes in drivers/spi/
       [not found]     ` <200707211124.53195.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
@ 2007-07-21 18:59       ` Jesper Juhl
  0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2007-07-21 18:59 UTC (permalink / raw)
  To: David Brownell
  Cc: David Brownell, Linux Kernel Mailing List, Aubrey Li,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	Andrew Morton, Nicolas Pitre

On 21/07/07, David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> On Saturday 21 July 2007, Jesper Juhl wrote:
> > Hi,
> >
> > This patch cleans up duplicate includes in
> >       drivers/spi/
> >
> >
> > Signed-off-by: Jesper Juhl <jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> ACK ... although, on general principles I suspect there are more
> needless includes to remove, these are just especially obvious.  :)
>
Yup. This patch series just removes the bulk of the low hanging fruit
- there's still more to do for an enterprising janitor in need of a
task. But you have to start somewhere :-)


-- 
Jesper Juhl <jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-21 18:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-21 15:02 [PATCH][14/37] Clean up duplicate includes in drivers/spi/ Jesper Juhl
     [not found] ` <200707211702.56466.jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-07-21 18:24   ` David Brownell
     [not found]     ` <200707211124.53195.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-07-21 18:59       ` Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).