From mboxrd@z Thu Jan  1 00:00:00 1970
From: Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 1/1] OMAP: McSPI: Off-by-one error in finding the right divisor
Date: Thu, 24 Feb 2011 09:10:52 -0700
Message-ID: <AANLkTi==YjWgmqO2GVX-B=VMumsEUz4JiOKVtHbHVq5R@mail.gmail.com>
References: <22be8985c86a32b9829ff740ce72bc4bd2e383cf.1298556551.git.ext-hannu.m.heikkinen@nokia.com>
 <20110224160045.GB17735@angua.secretlab.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Cc: linux-omap@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net,
	dbrownell@users.sourceforge.net, ext-phil.2.carmody@nokia.com
To: Hannu Heikkinen <ext-hannu.m.heikkinen@nokia.com>
Return-path: <linux-omap-owner@vger.kernel.org>
In-Reply-To: <20110224160045.GB17735@angua.secretlab.ca>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-spi.vger.kernel.org

On Thu, Feb 24, 2011 at 9:00 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Thu, Feb 24, 2011 at 04:13:31PM +0200, Hannu Heikkinen wrote:
>> Off-by-one error, gave erroneous divisor value 16 if speed_hz is over zero but
>> less than OMAP2_MCSPI_MAX_FREQ / (1 << 15), that is, [1..1463].
>>
>> Also few overly complex bit shifts in divisor fixed.
>>
>> Also one dev_dgb line fixed, which indicated max speed exceeding transfer speed.
>>
>> Introducing a new function omap2_mcspi_calc_divisor() for getting the right
>> divisor in omap2_mcspi_setup_transfer().
>>
>> Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
>> Signed-off-by: Hannu Heikkinen <ext-hannu.m.heikkinen@nokia.com>
>
> Applied, thanks

Patch adds a build warning:

  CC      drivers/spi/omap2_mcspi.o
linux-2.6/drivers/spi/omap2_mcspi.c: In function 'omap2_mcspi_setup_transfer':
linux-2.6/drivers/spi/omap2_mcspi.c:687: warning: comparison of
distinct pointer types lacks a cast

I've dropped it, please fix up and resubmit.

Thanks,
g.