From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cory Maccarrone Subject: Re: [spi-devel-general] [PATCH] Input: Add tsc2046 touchscreen driver Date: Sun, 30 May 2010 14:15:12 -0700 Message-ID: References: <885802.70948.qm@web180316.mail.gq1.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Dmitry Torokhov , spi-devel-general@lists.sourceforge.net, linux-input@vger.kernel.org To: David Brownell Return-path: In-Reply-To: <885802.70948.qm@web180316.mail.gq1.yahoo.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Sun, May 30, 2010 at 2:08 PM, David Brownell w= rote: > --- On Sun, 5/30/10, Cory Maccarrone wrote: > > I don't see the point in having a separate driver > for this chip ... it's just an updated ADS7846, > and the ads7846 driver has handled it for quite > a few years now, as I recall. =C2=A0There's no need for > =C2=A0second driver. > >> >> This driver differs from the ADS7846 in that it >> >> uses 16-bit commands instead of 8-bit, > > The reason the ads7846 code uses 8-bit messaging > is portability ... it works with SPI controllers > which don't support 16-bit words. =C2=A0The commands are > of necessity 16-bits. =C2=A0Using 16-bit words means this > driver won't run on as many systems; folk will still > need to use the ads7846 driver with tsc2046 chips.. > > > > =C2=A0and does not include >> temerature >> >> or voltage sensing capabilities. > > Another reason not to have a separate driver: this > one is less capable (as well as less portable) > > >> >> additions that allow >> >> the injection of pointercal parameters from tslib through /sys. > > Something the ads7846 driver could benefit from > too ... again, two drivers is counterproductive. > > - Dave > > I totally agree, thus my previous message. This submitted patch is no longer relevant. - Cory -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html