From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init Date: Wed, 24 Nov 2010 22:14:31 +0800 Message-ID: References: <1290597207-29838-1-git-send-email-bigeasy@linutronix.de> <1290597207-29838-2-git-send-email-bigeasy@linutronix.de> <4CED1C95.8070300@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: David Brownell , eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Mark Brown , linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Dirk Brandewie , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Sebastian Andrzej Siewior Return-path: In-Reply-To: <4CED1C95.8070300-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, Nov 24, 2010 at 10:09 PM, Sebastian Andrzej Siewior wrote: > Haojian Zhuang wrote: >> >> Hi Sebastian, > > Hi Hoajian, > >> Actually it's added for cpufreq usage. We can check the commit in below. >> >> =A0 =A0pxa2xx_spi: register earlier >> >> =A0 =A0Register pxa2xx_spi earlier so it can be used with cpufreq >> >> So I think that this modifcation may cause others brokne. > > I've been pointed out to this commit but I don't understand _why_. > The part I don't get is "so it can be used with cpufreq". Is it > refered to a driver or the subsystem as it? > As we know, cpufreq is used to adjust frequency and voltage of CPU. We need some interface to access PMIC hardware, such as I2C, SPI, .... So I think that they need SPI to initialize first. Otherwise, they may meet failure on accessing PMIC hardware. Thanks Haojian ---------------------------------------------------------------------------= --- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev