RE: [PATCH] SPI: S5P64X0: Enable SPI driver for S5P6440 and S5P6450

RE: [PATCH] SPI: S5P64X0: Enable SPI driver for S5P6440 and S5P6450

[Kukjin Kim]

Sangbeom Kim wrote:
> 
> From: Abhilash Kesavan <a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> 
> This patch enable the existing S3C64XX series SPI driver for S5P64X0
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Sangbeom Kim <sbkim73-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/spi/Kconfig |    4 ++--

Added following mailing list and maintainers.
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
David Brownell and Grant Likely (SPI Subsystem's maintainer)

>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 78f9fd0..56e6249 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -304,8 +304,8 @@ config SPI_S3C24XX_GPIO
> 
>  config SPI_S3C64XX
>  	tristate "Samsung S3C64XX series type SPI"
> -	depends on ARCH_S3C64XX && EXPERIMENTAL
> -	select S3C64XX_DMA
> +	depends on (ARCH_S3C64XX || ARCH_S5P64X0) && EXPERIMENTAL

Do we really still need CONFIG_EXPERIMENTAL here?

> +	select S3C64XX_DMA if !ARCH_S5P64X0
>  	help
>  	  SPI driver for Samsung S3C64XX and newer SoCs.

SPI driver for Samsung S3C64XX, S5P64X0 and newer Socs.


One more, did you test this on S5P64X0's board with just adding this?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev

Re: [PATCH] SPI: S5P64X0: Enable SPI driver for S5P6440 and S5P6450

[Jassi Brar]

On Fri, Dec 3, 2010 at 6:59 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sangbeom Kim wrote:
>>
>> From: Abhilash Kesavan <a.kesavan@samsung.com>
>>
>> This patch enable the existing S3C64XX series SPI driver for S5P64X0
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
>> ---
>>  drivers/spi/Kconfig |    4 ++--
>
> Added following mailing list and maintainers.
> spi-devel-general@lists.sourceforge.net
> David Brownell and Grant Likely (SPI Subsystem's maintainer)

I would have appreciated being CC'ed.

>>  config SPI_S3C64XX
>>       tristate "Samsung S3C64XX series type SPI"
>> -     depends on ARCH_S3C64XX && EXPERIMENTAL
>> -     select S3C64XX_DMA
>> +     depends on (ARCH_S3C64XX || ARCH_S5P64X0) && EXPERIMENTAL
>
> Do we really still need CONFIG_EXPERIMENTAL here?

I think we can drop it.


>> +     select S3C64XX_DMA if !ARCH_S5P64X0
>>       help
>>         SPI driver for Samsung S3C64XX and newer SoCs.
>
> SPI driver for Samsung S3C64XX, S5P64X0 and newer Socs.

S5P64X0 is already a part of  'newer Socs'