From: Clark Wang <xiaoning.wang@nxp.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: RE: [EXT] [PATCH] spi: imx: enable runtime pm support
Date: Tue, 24 Nov 2020 08:57:28 +0000 [thread overview]
Message-ID: <AM6PR04MB562348A699215824A00E29ECF3FB0@AM6PR04MB5623.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20201113091800.27469-1-nikita.shubin@maquefel.me>
Hi Nikita,
Sorry for this issue caused by my patch.
Yes, it because I did not add the !CONFIG_PM support when add the runtime pm patch. This may cause the clks cannot be enabled when do not enable CONFIG_PM.
Sascha has fix this issue with the patch:
43b6bf406cd0 spi: imx: fix runtime pm support for !CONFIG_PM
You may try the latest upstream driver again.
I also fix a warning dump issue with CONFIG_PM enabled. It is under reviewed. So that, this driver can work well in both cases.
Thanks!
Best Regards,
Clark Wang
> -----Original Message-----
> From: Nikita Shubin <nikita.shubin@maquefel.me>
> Sent: Friday, November 13, 2020 17:18
> To: Clark Wang <xiaoning.wang@nxp.com>
> Cc: broonie@kernel.org; festevam@gmail.com; kernel@pengutronix.de;
> linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>;
> linux-kernel@vger.kernel.org; linux-spi@vger.kernel.org;
> s.hauer@pengutronix.de; shawnguo@kernel.org; Nikita Shubin
> <nikita.shubin@maquefel.me>
> Subject: [EXT] [PATCH] spi: imx: enable runtime pm support
>
> Caution: EXT Email
>
> Hello Clark,
>
> This patch breaks spi-imx on imx7d.
> Toradex Colibri imx7d spi reports with:
>
> [ 4.258468] inv-mpu6000-spi spi2.0: I/O Error in PIO
> [ 4.264269] inv-mpu6000-spi spi2.0: SPI transfer failed: -110
> [ 4.264305] spi_master spi2: failed to transfer one message from queue
>
> We are using spi-imx with dma.
>
> Reverting your patch fixes this issue.
>
> The baseline commit 951cbbc386ff01b50da4f46387e994e81d9ab431 (tag:
> v5.9.8, stable/linux-5.9.y)
>
> Could you please give some comments on this issue ?
prev parent reply other threads:[~2020-11-24 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 6:33 [PATCH] spi: imx: enable runtime pm support Clark Wang
2020-07-27 13:57 ` Mark Brown
2020-11-13 9:18 ` Nikita Shubin
2020-11-13 11:26 ` Fabio Estevam
2020-11-13 12:04 ` nikita.shubin
2020-11-24 8:57 ` Clark Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB562348A699215824A00E29ECF3FB0@AM6PR04MB5623.eurprd04.prod.outlook.com \
--to=xiaoning.wang@nxp.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).