Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
From: Clark Wang <xiaoning.wang@nxp.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH V2 1/4] spi: lpspi: Fix kernel warning dump when probe fail after calling spi_register
Date: Fri, 31 Jul 2020 02:01:12 +0000
Message-ID: <AM6PR04MB56234CF41A225C8969ECE04DF34E0@AM6PR04MB5623.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200727111109.GB6275@sirena.org.uk>


> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Monday, July 27, 2020 19:11
> To: Clark Wang <xiaoning.wang@nxp.com>
> Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH V2 1/4] spi: lpspi: Fix kernel warning dump when
> probe fail after calling spi_register
> 
> On Mon, Jul 27, 2020 at 11:14:46AM +0800, Clark Wang wrote:
> > Calling devm_spi_register_controller() too early will cause problem.
> > When probe failed occurs after calling devm_spi_register_controller(),
> > the call of spi_controller_put() will trigger the following warning dump.
> >
> > [    2.092138] ------------[ cut here ]------------
> > [    2.096876] kernfs: can not remove 'uevent', no directory
> > [    2.102440] WARNING: CPU: 0 PID: 181 at fs/kernfs/dir.c:1503
> kernfs_remove_by_name_ns+0xa0/0xb0
> > [    2.111142] Modules linked in:
> > [    2.114207] CPU: 0 PID: 181 Comm: kworker/0:7 Not tainted 5.4.24-05024-
> g775c6e8a738c-dirty #1314
> > [    2.122991] Hardware name: Freescale i.MX8DXL EVK (DT)
> > [    2.128141] Workqueue: events deferred_probe_work_func
> 
> Please think hard before including complete backtraces in upstream reports,
> they are very large and contain almost no useful information relative to their
> size so often obscure the relevant content in your message. If part of the
> backtrace is usefully illustrative (it often is for search engines if nothing else)
> then it's usually better to pull out the relevant sections.

Hi Mark,

Thank you very much for reminding. 
I will remove the redundant part when I meet similar situations in the future. 😊

Best Regards,
Clark Wang

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  3:14 [PATCH V2 0/4] Some bug fix for lpspi Clark Wang
2020-07-27  3:14 ` [PATCH V2 1/4] spi: lpspi: Fix kernel warning dump when probe fail after calling spi_register Clark Wang
2020-07-27 11:11   ` Mark Brown
2020-07-31  2:01     ` Clark Wang [this message]
2020-07-27  3:14 ` [PATCH V2 2/4] spi: lpspi: remove unused fsl_lpspi->chipselect Clark Wang
2020-07-27  3:14 ` [PATCH V2 3/4] spi: lpspi: fix using CS discontinuously on i.MX8DXLEVK Clark Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB56234CF41A225C8969ECE04DF34E0@AM6PR04MB5623.eurprd04.prod.outlook.com \
    --to=xiaoning.wang@nxp.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git