From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH V2 0/6] spi/spi-pl022 fixes Date: Thu, 1 Sep 2011 12:56:05 +0200 Message-ID: References: <4E5F58BB.4020205@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Vipin KUMAR , Rajeev KUMAR , Bhavna YADAV , Bhupesh SHARMA , Pratyush ANAND , Armando VISCONTI , "jassisinghbrar@gmail.com" , "grant.likely@secretlab.ca" , Shiraz HASHIM , Amit VIRDI , Vipul Kumar SAMAR , "viresh.linux@gmail.com" , Deepak SIKRI , "spi-devel-general@lists.sourceforge.net" , "linux-arm-kernel@lists.infradead.org" To: Viresh Kumar Return-path: In-Reply-To: <4E5F58BB.4020205@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On Thu, Sep 1, 2011 at 12:04 PM, Viresh Kumar wrote: > On 8/10/2011 2:20 PM, Viresh KUMAR wrote: >> >> This patchset mainly covers following fixes: >> - formatting related issues >> - Passing GFP_ATOMIC for sg allocation from tasklet >> - Fixing calculate_effective_freq() routine >> - Allocate/free DMA channels as and when required. >> > > Grant, > > Did you already pushed this patchset? > There are few concerns on PATCH 6/6 and i am not sure if there are any decisions > on it. > @Linus: What do you say? I agree. Acked-by: Linus Walleij for all except 6/6, it's probably just as possible to keep the channel handle taken in the driver if we modify the affected DMA driver instead. This would be better for performance I think. Thanks, Linus Walleij