From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH 2/3] spi: spi-geni-qcom: Grow a dev pointer to simplify code Date: Tue, 4 Feb 2020 13:07:56 -0800 Message-ID: References: <20200204191206.97036-1-swboyd@chromium.org> <20200204191206.97036-3-swboyd@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Mark Brown , LKML , Andy Gross , Bjorn Andersson , linux-spi , Girish Mahadevan , Dilip Kota , Alok Chauhan To: Stephen Boyd Return-path: In-Reply-To: <20200204191206.97036-3-swboyd-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi, On Tue, Feb 4, 2020 at 11:12 AM Stephen Boyd wrote: > > Some lines are long here. Use a struct dev pointer to shorten lines and > simplify code. The clk_get() call can fail because of EPROBE_DEFER > problems too, so just remove the error print message because it isn't > useful. > > Cc: Girish Mahadevan > Cc: Dilip Kota > Cc: Alok Chauhan > Cc: Douglas Anderson > Signed-off-by: Stephen Boyd > --- > drivers/spi/spi-geni-qcom.c | 24 +++++++++++------------- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > index 46e501fc87f3..f0ca7f5ae714 100644 > --- a/drivers/spi/spi-geni-qcom.c > +++ b/drivers/spi/spi-geni-qcom.c > @@ -536,6 +536,7 @@ static int spi_geni_probe(struct platform_device *pdev) > struct spi_geni_master *mas; > void __iomem *base; > struct clk *clk; > + struct device *dev = &pdev->dev; > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > @@ -545,28 +546,25 @@ static int spi_geni_probe(struct platform_device *pdev) > if (IS_ERR(base)) > return PTR_ERR(base); > > - clk = devm_clk_get(&pdev->dev, "se"); > - if (IS_ERR(clk)) { > - dev_err(&pdev->dev, "Err getting SE Core clk %ld\n", > - PTR_ERR(clk)); > + clk = devm_clk_get(dev, "se"); > + if (IS_ERR(clk)) There could be other errors besides -EPROBE_DEFER and devm_clk_get() won't have printed in all cases. ...but I agree that it seems highly unlikely we'd ever hit any of those but highly likely we _would_ print out a needless shout about -EPROBE_DEFER, so this is fine: Reviewed-by: Douglas Anderson