Linux-SPI Archive on
 help / color / Atom feed
From: Doug Anderson <>
To: Mark Brown <>
Cc: linux-arm-msm <>,
	Stephen Boyd <>,
	Dilip Kota <>,
	Bjorn Andersson <>,
	Andy Gross <>,
	LKML <>,
	linux-spi <>
Subject: Re: [PATCH] spi: spi-geni-qcom: Don't set the cs if it was already right
Date: Mon, 29 Jun 2020 16:45:30 -0700
Message-ID: <> (raw)
In-Reply-To: <>


On Mon, Jun 29, 2020 at 4:53 AM Mark Brown <> wrote:
> On Fri, Jun 26, 2020 at 03:19:50PM -0700, Douglas Anderson wrote:
> > Setting the chip select on the Qualcomm geni SPI controller isn't
> > exactly cheap.  Let's cache the current setting and avoid setting the
> > chip select if it's already right.
> Seems like it'd be worth pushing this up to the core - if we're
> constantly setting the same CS value then perhaps we ought to just stop
> doing that?


spi: Avoid setting the chip select if we don't need to

I see that you applied my patch to "spi-geni-qcom".  If the patch to
the core looks OK to you and lands, I think the one for the driver can
be reverted (though it doesn't hurt).


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 22:19 Douglas Anderson
2020-06-29 11:53 ` Mark Brown
2020-06-29 23:45   ` Doug Anderson [this message]
2020-06-29 19:38 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPI Archive on

Archives are clonable:
	git clone --mirror linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ \
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone