From: prahlad venkata <prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>,
Prahlad V <prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable
Date: Tue, 22 Nov 2016 12:54:06 +0530 [thread overview]
Message-ID: <CAFbo-qWmvm02wpkWT0hgX6qu6jOStmwAXHBWbjbAQ=fwv0WPng@mail.gmail.com> (raw)
In-Reply-To: <20161115182643.32217-1-prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Did anybody got chance to review this patch?
I feel this is a trivial yet required fix.
On Tue, Nov 15, 2016 at 11:56 PM, Prahlad V <prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> completion variable should be reinitialized before reusing.
>
> Signed-off-by: Prahlad V <prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/spi/spi-ti-qspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index caeac66..ec6fb09 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
> tx->callback = ti_qspi_dma_callback;
> tx->callback_param = qspi;
> cookie = tx->tx_submit(tx);
> + reinit_completion(&qspi->transfer_complete);
>
> ret = dma_submit_error(cookie);
> if (ret) {
> --
> 2.9.2.729.ga42d7b6
>
--
Regards,
Prahlad.
+91-9663742838
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-22 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 18:26 [PATCH] spi: spi-ti-qspi: reinit of completion variable Prahlad V
2016-11-15 18:53 ` Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree Mark Brown
[not found] ` <20161115182643.32217-1-prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-22 7:24 ` prahlad venkata [this message]
[not found] ` <CAFbo-qWmvm02wpkWT0hgX6qu6jOStmwAXHBWbjbAQ=fwv0WPng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-22 12:27 ` [PATCH] spi: spi-ti-qspi: reinit of completion variable Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFbo-qWmvm02wpkWT0hgX6qu6jOStmwAXHBWbjbAQ=fwv0WPng@mail.gmail.com' \
--to=prahlad.eee-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vigneshr-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).