linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Ford <aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Han Xu <han.xu-3arQi8VN3Tc@public.gmane.org>,
	Yogesh Gaur
	<yogeshgaur.83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ashish Kumar <ashish.kumar-3arQi8VN3Tc@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Pengutronix Kernel Team
	<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	NXP Linux Team <linux-imx-3arQi8VN3Tc@public.gmane.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH V2 2/5] spi: fspi: dynamically alloc AHB memory
Date: Mon, 3 Feb 2020 04:53:34 -0600	[thread overview]
Message-ID: <CAHCN7xJyZRwJhnWW2mAbOeGyrMsB7Au_e6AvwiNmNS8gFUfSyw@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5D3emrAk84wDS04qJC-3AyvFnqodhoMsXO-ukHnYsU+PQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Sun, Feb 2, 2020 at 10:39 AM Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> On Sun, Feb 2, 2020 at 10:00 AM Adam Ford <aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> > From: Han Xu <han.xu-3arQi8VN3Tc@public.gmane.org>
> >
> > Apply patch from NXP upstream repo to
> > dynamically allocate AHB memory as needed.
>
> The commit log could be improved here. What is the motivation for doing this?

My motivation is to get the flexspi on the i.MX8MM to work, and I did
a list of the patches applied on the NXP branch to see what was
applied on top of their 4.19 kernel and this patch series generated
from that list.  Most of the NXP commits are one-line commits, and I
don't know the motivation for what's happening.  NXP did it, and I
know it works on the Flexspi driver.

Maybe Han Xu can comment, since it's really his patch.


adam
>
> > +               if (!f->ahb_addr) {
> > +                       dev_err(f->dev, "failed to alloc memory\n");
>
> There is no need for this error message as the MM core will take care of it.

  parent reply	other threads:[~2020-02-03 10:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 12:59 [PATCH V2 1/5] spi: fspi: enable fspi on imx8qxp and imx8mm Adam Ford
     [not found] ` <20200202125950.1825013-1-aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-02 12:59   ` [PATCH V2 2/5] spi: fspi: dynamically alloc AHB memory Adam Ford
     [not found]     ` <20200202125950.1825013-2-aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-02 16:39       ` Fabio Estevam
     [not found]         ` <CAOMZO5D3emrAk84wDS04qJC-3AyvFnqodhoMsXO-ukHnYsU+PQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-03 10:53           ` Adam Ford [this message]
     [not found]             ` <CAHCN7xJyZRwJhnWW2mAbOeGyrMsB7Au_e6AvwiNmNS8gFUfSyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-12 12:07               ` Mark Brown
     [not found]                 ` <20200212120753.GF4028-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-02-12 13:08                   ` Adam Ford
     [not found]                     ` <CAHCN7x+5bACfYVX49Lib+fmNq-dEOkcyi0gXt7rtYxrGaYbH1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-13 18:46                       ` Mark Brown
     [not found]                         ` <20200213184624.GK4333-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-02-15 16:14                           ` [EXT] " Han Xu
2020-02-02 12:59   ` [PATCH V2 4/5] dt-bindings: spi: spi-nxp-fspi: Add support for imx8mm, imx8qxp Adam Ford
     [not found]     ` <20200202125950.1825013-4-aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-06 18:40       ` Rob Herring
2020-02-11 10:49         ` Adam Ford
     [not found]           ` <CAHCN7x+uCwyJ60ZG_0m5SgNmqUAyEwxqXVTL7nQzJLXxXrh+Tw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-11 18:05             ` Rob Herring
2020-02-02 12:59   ` [PATCH V2 5/5] arm64: dts: enable fspi in imx8mm dts Adam Ford
     [not found]     ` <20200202125950.1825013-5-aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-14  3:36       ` Shawn Guo
2020-02-02 12:59 ` [PATCH V2 3/5] spi: spi-nxp-fspi: Enable the Octal Mode in MCR0 Adam Ford
     [not found]   ` <20200202125950.1825013-3-aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-12 12:04     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHCN7xJyZRwJhnWW2mAbOeGyrMsB7Au_e6AvwiNmNS8gFUfSyw@mail.gmail.com \
    --to=aford173-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ashish.kumar-3arQi8VN3Tc@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=han.xu-3arQi8VN3Tc@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-imx-3arQi8VN3Tc@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=yogeshgaur.83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).