Linux-SPI Archive on
 help / color / Atom feed
From: Andy Shevchenko <>
To: Andy Shevchenko <>
Cc: Mark Brown <>,
	linux-spi <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH v1 1/1] spi: Don't overwrite num_chipselect with error code
Date: Tue, 20 Apr 2021 17:33:12 +0300
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Apr 20, 2021 at 4:19 PM Andy Shevchenko
<> wrote:
> The code currently organized in a way that num_chipselect is overwritten
> each time we call spi_get_gpio_descs(). It might be potentially dangerous
> in case when the gpiod_count() returns an error code.
> Note, that gpiod_count() never returns 0, take this into account as well.
> Fixes: f3186dd87669 ("spi: Optionally use GPIO descriptors for CS GPIOs")

It doesn't fix anything. I missed the max_t(int).
In any case it makes error handling cleaner, so I'll reformulate the
commit message in v2 and drop Fixes tag.

With Best Regards,
Andy Shevchenko

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 13:19 Andy Shevchenko
2021-04-20 14:33 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPI Archive on

Archives are clonable:
	git clone --mirror linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ \
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone