From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Dan O'Donovan" <dan@emutex.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Jarkko Nikula <jarkko.nikula@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Len Brown <lenb@kernel.org>,
linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
linux-spi <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Crestez Dan Leonard <leonard.crestez@intel.com>
Subject: Re: [PATCH v3 2/3] i2c: acpi: Initialize info.type from of_compatible
Date: Mon, 23 Jan 2017 19:10:13 +0200 [thread overview]
Message-ID: <CAHp75VdzGLem7c6Ur9Bj1UtJ56XdEii7SgRbe5yT5hew8yQO0g@mail.gmail.com> (raw)
In-Reply-To: <1485187737-22414-3-git-send-email-dan@emutex.com>
On Mon, Jan 23, 2017 at 6:08 PM, Dan O'Donovan <dan@emutex.com> wrote:
> From: Crestez Dan Leonard <leonard.crestez@intel.com>
>
> When using devicetree i2c_board_info.type is set to the compatible
> string with the vendor prefix removed. For I2C devices described via
> ACPI the i2c_board_info.type string is set to the ACPI device name. When
> using ACPI and DT ids this string ends up something like "PRP0001:00".
>
> If the of_compatible property is present try to use that instead. This
> makes it easier to instantiate i2c drivers through ACPI with DT ids.
> - strlcpy(info->type, dev_name(&adev->dev), sizeof(info->type));
> + /*
> + * Populate modalias from compatible property if available,
> + * otherwise use native ACPI information
> + */
> + if ((!adev->data.of_compatible) ||
> + acpi_of_modalias(adev, info->type, sizeof(info->type)))
Redundant parens in lvalue. After removing them is it possible to use
one line for it?
> + strlcpy(info->type, dev_name(&adev->dev), sizeof(info->type));
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-01-23 17:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 11:53 [PATCH v2 0/3] Init device ids from ACPI of_compatible Crestez Dan Leonard
2016-07-13 11:53 ` [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible Crestez Dan Leonard
2016-07-13 12:22 ` Rafael J. Wysocki
2016-07-19 7:08 ` Mika Westerberg
2016-07-19 10:22 ` Mark Brown
2016-07-20 11:21 ` Crestez Dan Leonard
2016-07-20 11:37 ` Mark Brown
[not found] ` <cover.1468409668.git.leonard.crestez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-13 11:53 ` [PATCH v2 1/3] acpi: Export acpi_of_modalias equiv of of_modalias_node Crestez Dan Leonard
[not found] ` <fde8d7c9312a887553feab9877a33f01e5ceda47.1468409668.git.leonard.crestez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-13 12:19 ` Rafael J. Wysocki
2016-07-19 7:14 ` Mika Westerberg
2016-07-13 11:53 ` [PATCH v2 2/3] acpi i2c: Initialize info.type from of_compatible Crestez Dan Leonard
2016-07-13 12:20 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0jz-E0RTBWVzO0Vc_jChUSeSseFeewi1UtsjLudoVP7Pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-19 7:07 ` Mika Westerberg
2016-07-13 12:09 ` [PATCH v2 0/3] Init device ids from ACPI of_compatible Rafael J. Wysocki
2016-07-13 14:15 ` Dan O'Donovan
2017-01-23 16:08 ` [PATCH v3 " Dan O'Donovan
2017-01-23 16:08 ` [PATCH v3 2/3] i2c: acpi: Initialize info.type from of_compatible Dan O'Donovan
2017-01-23 17:10 ` Andy Shevchenko [this message]
[not found] ` <1485187737-22414-1-git-send-email-dan-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
2017-01-23 16:08 ` [PATCH v3 1/3] ACPI / bus: Export acpi_of_modalias equiv of of_modalias_node Dan O'Donovan
2017-01-23 16:08 ` [PATCH v3 3/3] spi: acpi: Initialize modalias from of_compatible Dan O'Donovan
2017-01-23 17:11 ` Andy Shevchenko
2017-01-27 10:35 ` Dan O'Donovan
2017-01-27 13:43 ` Andy Shevchenko
2017-01-30 9:41 ` Rafael J. Wysocki
2017-01-31 20:17 ` Mark Brown
[not found] ` <20170131201736.cmiyq2obzrhgdsck-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-01-31 21:18 ` Rafael J. Wysocki
2017-01-23 17:13 ` [PATCH v3 0/3] Init device ids from ACPI of_compatible Andy Shevchenko
2017-01-24 15:11 ` Jarkko Nikula
[not found] ` <6ff3138c-ac16-d310-28b7-cee0b0e5f11c-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-24 15:19 ` Andy Shevchenko
2017-01-27 13:30 ` [PATCH v4 " Dan O'Donovan
2017-01-27 13:30 ` [PATCH v4 1/3] ACPI / bus: Export acpi_of_modalias equiv of of_modalias_node Dan O'Donovan
2017-02-02 11:41 ` Rafael J. Wysocki
2017-02-02 13:30 ` Dan O'Donovan
2017-01-27 13:30 ` [PATCH v4 2/3] i2c: acpi: Initialize info.type from of_compatible Dan O'Donovan
2017-01-28 21:38 ` Wolfram Sang
2017-01-27 13:30 ` [PATCH v4 3/3] spi: acpi: Initialize modalias " Dan O'Donovan
2017-02-01 18:34 ` Mark Brown
2017-02-04 8:00 ` [PATCH v5 0/3] Init device ids from ACPI of_compatible Dan O'Donovan
2017-02-04 8:00 ` [PATCH v5 1/3] ACPI / bus: Export acpi_of_modalias equiv of of_modalias_node Dan O'Donovan
[not found] ` <1486195228-10929-1-git-send-email-dan-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
2017-02-04 8:00 ` [PATCH v5 2/3] i2c: acpi: Initialize info.type from of_compatible Dan O'Donovan
2017-02-04 8:00 ` [PATCH v5 3/3] spi: acpi: Initialize modalias " Dan O'Donovan
2017-02-04 10:16 ` Mark Brown
2017-02-05 16:30 ` [PATCH v6 0/3] Init device ids from ACPI of_compatible Dan O'Donovan
2017-02-05 16:30 ` [PATCH v6 1/3] ACPI / bus: Export acpi_of_modalias equiv of of_modalias_node Dan O'Donovan
2017-02-05 16:30 ` [PATCH v6 2/3] i2c: acpi: Initialize info.type from of_compatible Dan O'Donovan
2017-02-05 16:30 ` [PATCH v6 3/3] spi: acpi: Initialize modalias " Dan O'Donovan
[not found] ` <1486312214-20770-4-git-send-email-dan-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
2017-02-06 16:31 ` Mark Brown
[not found] ` <1486312214-20770-1-git-send-email-dan-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
2017-02-09 13:53 ` [PATCH v6 0/3] Init device ids from ACPI of_compatible Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdzGLem7c6Ur9Bj1UtJ56XdEii7SgRbe5yT5hew8yQO0g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=dan@emutex.com \
--cc=jarkko.nikula@intel.com \
--cc=lenb@kernel.org \
--cc=leonard.crestez@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).