From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F28EC433E0 for ; Sat, 25 Jul 2020 10:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3346F20674 for ; Sat, 25 Jul 2020 10:45:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E9dx9GXW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726639AbgGYKpB (ORCPT ); Sat, 25 Jul 2020 06:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbgGYKpB (ORCPT ); Sat, 25 Jul 2020 06:45:01 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14220C0619D3; Sat, 25 Jul 2020 03:45:01 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id md7so6813420pjb.1; Sat, 25 Jul 2020 03:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mw7/94BNaGAP671q/l4zcNRypbQ7/HXqY8h0Z+X694Y=; b=E9dx9GXWAwQ7BS1lvhzr3sZfUxFAkQCxs5IbeVy6jaQBBHsu94zA60eqL7E+EYJo3Q o5M+JZQTvCGluvRrFru0n9ayJVBFbIPfRMQE3qHhtea2kG1q7aVghq19KypExGrLAUjv rqkoqBHRFNw0zGwNJJ7iwYwjWq4UEfVTDiIlgjoTnK5Qk+oJn7BF6JvErc+BT17cAe+D b3RMdbOnWIRDid3pzE+IeXsA5eUKrikE6bw4eUpym3hL+75cArFaB7Oe6L0E3hrAgpWn saFfcPuc743cXNpG/pAQ+Xnqlixj6NgfwXV6ybUWRxa9hfHHASeXsmQQO50KX+HUcRhv wP+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mw7/94BNaGAP671q/l4zcNRypbQ7/HXqY8h0Z+X694Y=; b=bbpIkzsWgjEFuYLiO1m/vDz//BK06WCgePNEv3Uag/WuppLtSiqctdDwzjfk2rk+sx /OL6Gfexgr7q0gXTJw3ZSZ72uuJJeJJc7FZGA77qa8TYmVvzUwzMg9BQf+Q1XBPhPrtN dmVb+1uCbZVhxKwwyX2u4av/WqGKDXRlu5o/CGcX1r3DxfpSC1DU7UZ6vsDEf3Xzez9W XTHRE3DMMgve5f6WCKGg6yunVmaV9ZxG8fnmoRYP+SUxaYYUBpIJjpyqHNx3yS9w6JHr OFMGg6txMvMFDiJR/59cOR9qgwOpLNE74FlGCR3BTco5DddB9CB9SNE5ZWd6dRkWRE6z WnsA== X-Gm-Message-State: AOAM531KPNpLAbLBohLFHfRVUFHS91cVdSHk7wGP+v27cuFsg/LCiSW0 qwbPN64VgmksJgXudiEaNdKkvOs2J2rmbj+YSQY= X-Google-Smtp-Source: ABdhPJyZDOpYfyd7juxBE+IWrL4ffBNacFmyQCYFqqh7ePdTGjI1aHlUpxfwYpP49GEn93LRwwbAcoFpFZzFsh2mt/M= X-Received: by 2002:a17:90a:498b:: with SMTP id d11mr10012883pjh.129.1595673900537; Sat, 25 Jul 2020 03:45:00 -0700 (PDT) MIME-Version: 1.0 References: <20200724223746.GA1538991@bjorn-Precision-5520> In-Reply-To: From: Andy Shevchenko Date: Sat, 25 Jul 2020 13:44:44 +0300 Message-ID: Subject: Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management To: Bjorn Helgaas Cc: Vaibhav Gupta , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mark Brown , linux-spi , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko wrote: > On Sat, Jul 25, 2020 at 1:37 AM Bjorn Helgaas wrote: > > On Fri, Jul 24, 2020 at 11:16:55PM +0300, Andy Shevchenko wrote: ... > > If it's a bug that spi-topcliff-pch.c disables but never enables > > wakeup, I think this should turn into two patches: > > > > 1) Fix the bug by enabling wakeup in suspend (or whatever the right > > fix is), and > > > > 2) Convert to generic PM, which may involve removing the > > wakeup-related code completely. > > Works for me. The only problem here, is that the 2nd is already in the Mark's tree and he doesn't do rebases. So, it will be the other way around. -- With Best Regards, Andy Shevchenko