From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chuanhong Guo Subject: Re: [PATCH resend 1/2] spi: add driver for ar934x spi controller Date: Thu, 6 Feb 2020 20:33:33 +0800 Message-ID: References: <20200206084443.209719-1-gch981213@gmail.com> <20200206084443.209719-2-gch981213@gmail.com> <20200206113158.GK3897@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, open list , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" To: Mark Brown Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, Feb 6, 2020 at 8:30 PM Chuanhong Guo wrote: > > It looks like this could just be a transfer_one() operation > > instead of transfer_one_message() (which is what this is in spite > > of the name)? There's nothing custom outside this loop that I > > can see. > > Chipselect is also handled during transfer. Controller asserts > corresponding chipselect in SHIFT_CTRL register, and if SHIFT_TERM bit > is set, controller will deassert chipselect after current transfer is > done. I need to know whether this is the last transfer and set > SHIFT_TERM accordingly. Oh, I remembered that I saw transfer_one function name somewhere and thought maybe I could shorten the function name a bit. I'll correct this back to ar934x_spi_transfer_one_message in v2. Regards, Chuanhong Guo